- ngIRCd GIT Updates - lists.barton.de

Alexander Barton : Xcode: correctly sort conn-ssl.{c|h} files in file list
by alex＠arthur.barton.de 17 Apr '12

17 Apr '12

Module: ngircd.git Branch: master Commit: 69be7a85a2117f0526ca4e113a806be989dc2f53 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=69be7a85… Author: Alexander Barton <alex(a)barton.de> Date: Tue Apr 17 12:57:27 2012 +0200 Xcode: correctly sort conn-ssl.{c|h} files in file list --- contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj index b6e51c7..289c2ed 100644 --- a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj +++ b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj @@ -305,8 +305,6 @@ isa = PBXGroup; children = ( FA322D020CEF74B1001761B3 /* Makefile.am */, - FAA3D2790F139CDC00B2447E /* conn-ssl.c */, - FAA3D27A0F139CDC00B2447E /* conn-ssl.h */, FA322CD90CEF74B1001761B3 /* array.c */, FA322CDA0CEF74B1001761B3 /* array.h */, FA322CDB0CEF74B1001761B3 /* channel.c */, @@ -324,6 +322,8 @@ FA322CE40CEF74B1001761B3 /* conn-zip.h */, FA322CE50CEF74B1001761B3 /* conn.c */, FA322CE60CEF74B1001761B3 /* conn.h */, + FAA3D2790F139CDC00B2447E /* conn-ssl.c */, + FAA3D27A0F139CDC00B2447E /* conn-ssl.h */, FA322CE70CEF74B1001761B3 /* defines.h */, FA322CE80CEF74B1001761B3 /* hash.c */, FA322CE90CEF74B1001761B3 /* hash.h */,

1 0

Alexander Barton : Lists_Add(): use size of destination when copying data
by alex＠arthur.barton.de 17 Apr '12

17 Apr '12

Module: ngircd.git Branch: master Commit: 8ec17063a6e651229e04605592ce3d6114075655 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=8ec17063… Author: Alexander Barton <alex(a)barton.de> Date: Tue Apr 17 12:54:38 2012 +0200 Lists_Add(): use size of destination when copying data This fixes the following warning of clang: /src/ngircd/lists.c:152:44: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] But it isn't a real problem, because the size of the source always is the same than the size of the destination ... --- src/ngircd/lists.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ngircd/lists.c b/src/ngircd/lists.c index 4f57ca7..45a4874 100644 --- a/src/ngircd/lists.c +++ b/src/ngircd/lists.c @@ -149,7 +149,8 @@ Lists_Add(struct list_head *h, const char *Mask, time_t ValidUntil, if (Reason) { newelem->reason = malloc(strlen(Reason) + 1); if (newelem->reason) - strlcpy(newelem->reason, Reason, strlen(Reason) + 1); + strlcpy(newelem->reason, Reason, + sizeof(newelem->reason)); else Log(LOG_EMERG, "Can't allocate memory for new list reason text!");

1 0

Alexander Barton : Add missing documentation files to Xcode project
by alex＠arthur.barton.de 31 Mär '12

31 Mär '12

Module: ngircd.git Branch: master Commit: 9f3af061cf4a48c2d580a4bb42eb49c71b96e09d URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=9f3af061… Author: Alexander Barton <alex(a)barton.de> Date: Sat Mar 31 12:51:33 2012 +0200 Add missing documentation files to Xcode project --- contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj | 22 +++++++++++++++++----- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj index 695eeee..b6e51c7 100644 --- a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj +++ b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj @@ -231,6 +231,12 @@ FAA97C56124A271400D5BBA9 /* sighandlers.h */ = {isa = PBXFileReference; fileEncoding = 5; lastKnownFileType = sourcecode.c.h; path = sighandlers.h; sourceTree = "<group>"; }; FAACD5F314A6099C006ED74F /* class.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = class.c; sourceTree = "<group>"; }; FAACD5F414A6099C006ED74F /* class.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = class.h; sourceTree = "<group>"; }; + FAE22BD215270EA300F1A5AB /* Bopm.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = Bopm.txt; sourceTree = "<group>"; }; + FAE22BD415270EA300F1A5AB /* Contributing.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = Contributing.txt; sourceTree = "<group>"; }; + FAE22BD515270EB500F1A5AB /* HowToRelease.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = HowToRelease.txt; sourceTree = "<group>"; }; + FAE22BD615270EB500F1A5AB /* Modes.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = Modes.txt; sourceTree = "<group>"; }; + FAE22BD715270EB500F1A5AB /* PAM.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = PAM.txt; sourceTree = "<group>"; }; + FAE22BD815270EC400F1A5AB /* README-Interix.txt */ = {isa = PBXFileReference; lastKnownFileType = text; path = "README-Interix.txt"; sourceTree = "<group>"; }; FAE5CC2C0CF2308A007D69B6 /* numeric.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = numeric.h; sourceTree = "<group>"; }; FAE5CC2D0CF2308A007D69B6 /* numeric.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = numeric.c; sourceTree = "<group>"; }; /* End PBXFileReference section */ @@ -298,6 +304,7 @@ FA322CD70CEF74B1001761B3 /* ngircd */ = { isa = PBXGroup; children = ( + FA322D020CEF74B1001761B3 /* Makefile.am */, FAA3D2790F139CDC00B2447E /* conn-ssl.c */, FAA3D27A0F139CDC00B2447E /* conn-ssl.h */, FA322CD90CEF74B1001761B3 /* array.c */, @@ -344,7 +351,6 @@ FA322CFF0CEF74B1001761B3 /* lists.h */, FA322D000CEF74B1001761B3 /* log.c */, FA322D010CEF74B1001761B3 /* log.h */, - FA322D020CEF74B1001761B3 /* Makefile.am */, FA322D030CEF74B1001761B3 /* match.c */, FA322D040CEF74B1001761B3 /* match.h */, FA322D050CEF74B1001761B3 /* messages.h */, @@ -563,18 +569,24 @@ FA322D970CEF752C001761B3 /* doc */ = { isa = PBXGroup; children = ( - FAA3D2800F139D1500B2447E /* Services.txt */, - FA407F380DB15AC700271AF1 /* GIT.txt */, - FA322D9A0CEF752C001761B3 /* FAQ.txt */, FA322D9B0CEF752C001761B3 /* Makefile.am */, + FAE22BD215270EA300F1A5AB /* Bopm.txt */, + FAE22BD415270EA300F1A5AB /* Contributing.txt */, + FA322D9A0CEF752C001761B3 /* FAQ.txt */, + FA407F380DB15AC700271AF1 /* GIT.txt */, + FAE22BD515270EB500F1A5AB /* HowToRelease.txt */, + FAE22BD615270EB500F1A5AB /* Modes.txt */, + FAE22BD715270EB500F1A5AB /* PAM.txt */, FA322D9C0CEF752C001761B3 /* Platforms.txt */, FA322D9D0CEF752C001761B3 /* Protocol.txt */, FA322D9E0CEF752C001761B3 /* README-AUX.txt */, FA322D9F0CEF752C001761B3 /* README-BeOS.txt */, + FAE22BD815270EC400F1A5AB /* README-Interix.txt */, FA322DA00CEF752C001761B3 /* RFC.txt */, + FAA3D2800F139D1500B2447E /* Services.txt */, + FA322DA90CEF752C001761B3 /* SSL.txt */, FA77849A133FB9FF00740057 /* sample-ngircd.conf.tmpl */, FA322DA20CEF752C001761B3 /* src */, - FA322DA90CEF752C001761B3 /* SSL.txt */, ); name = doc; path = ../../doc;

1 0

Alexander Barton : Makefiles: list each source files on a separate line
by alex＠arthur.barton.de 31 Mär '12

31 Mär '12

Module: ngircd.git Branch: master Commit: 67bd1bf34fc3f7bebb304cdf84284523c8ea09f5 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=67bd1bf3… Author: Alexander Barton <alex(a)barton.de> Date: Sat Mar 31 12:52:58 2012 +0200 Makefiles: list each source files on a separate line Patches that add/remove source files become much nicer this way :-) --- doc/Makefile.am | 20 ++++++++++-- src/ngircd/Makefile.am | 79 +++++++++++++++++++++++++++++++++++++++++------- 2 files changed, 84 insertions(+), 15 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index c153fec..1a792c5 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,6 +1,6 @@ # # ngIRCd -- The Next Generation IRC Daemon -# Copyright (c)2001-2011 Alexander Barton (alex(a)barton.de) and Contributors +# Copyright (c)2001-2012 Alexander Barton (alex(a)barton.de) and Contributors # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,9 +16,21 @@ SUFFIXES = .tmpl -static_docs = Bopm.txt FAQ.txt GIT.txt HowToRelease.txt Modes.txt PAM.txt \ - Platforms.txt Protocol.txt README-AUX.txt README-BeOS.txt \ - README-Interix.txt RFC.txt SSL.txt Services.txt +static_docs = \ + Bopm.txt \ + FAQ.txt \ + GIT.txt \ + HowToRelease.txt \ + Modes.txt \ + PAM.txt \ + Platforms.txt \ + Protocol.txt \ + README-AUX.txt \ + README-BeOS.txt \ + README-Interix.txt \ + RFC.txt \ + Services.txt \ + SSL.txt doc_templates = sample-ngircd.conf.tmpl diff --git a/src/ngircd/Makefile.am b/src/ngircd/Makefile.am index 450547e..cacd1c3 100644 --- a/src/ngircd/Makefile.am +++ b/src/ngircd/Makefile.am @@ -1,6 +1,6 @@ # # ngIRCd -- The Next Generation IRC Daemon -# Copyright (c)2001-2010 Alexander Barton (alex(a)barton.de) +# Copyright (c)2001-2012 Alexander Barton (alex(a)barton.de) # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,21 +18,78 @@ LINTARGS = -weak -warnunixlib +unixlib -booltype BOOLEAN \ sbin_PROGRAMS = ngircd -ngircd_SOURCES = ngircd.c array.c channel.c class.c client.c conf.c conn.c \ - conn-func.c conn-ssl.c conn-zip.c hash.c io.c irc.c irc-channel.c \ - irc-info.c irc-login.c irc-mode.c irc-op.c irc-oper.c irc-server.c \ - irc-write.c lists.c log.c match.c op.c numeric.c pam.c parse.c \ - proc.c resolve.c sighandlers.c +ngircd_SOURCES = \ + ngircd.c \ + array.c \ + channel.c \ + class.c \ + client.c \ + conf.c \ + conn.c \ + conn-func.c \ + conn-ssl.c \ + conn-zip.c \ + hash.c \ + io.c \ + irc.c \ + irc-channel.c \ + irc-info.c \ + irc-login.c \ + irc-mode.c \ + irc-op.c \ + irc-oper.c \ + irc-server.c \ + irc-write.c \ + lists.c \ + log.c \ + match.c \ + numeric.c \ + op.c \ + pam.c \ + parse.c \ + proc.c \ + resolve.c \ + sighandlers.c ngircd_LDFLAGS = -L../portab -L../tool -L../ipaddr ngircd_LDADD = -lngportab -lngtool -lngipaddr -noinst_HEADERS = ngircd.h array.h channel.h class.h client.h conf.h \ - conf-ssl.h conn.h conn-func.h conn-ssl.h conn-zip.h hash.h io.h \ - irc.h irc-channel.h irc-info.h irc-login.h irc-mode.h irc-op.h \ - irc-oper.h irc-server.h irc-write.h lists.h log.h match.h numeric.h \ - op.h pam.h parse.h proc.h resolve.h sighandlers.h defines.h messages.h +noinst_HEADERS = \ + ngircd.h \ + array.h \ + channel.h \ + class.h \ + client.h \ + conf.h \ + conf-ssl.h \ + conn.h \ + conn-func.h \ + conn-ssl.h \ + conn-zip.h \ + defines.h \ + hash.h \ + io.h \ + irc.h \ + irc-channel.h \ + irc-info.h \ + irc-login.h \ + irc-mode.h \ + irc-op.h \ + irc-oper.h \ + irc-server.h \ + irc-write.h \ + lists.h \ + log.h \ + match.h \ + messages.h \ + numeric.h \ + op.h \ + pam.h \ + parse.h \ + proc.h \ + resolve.h \ + sighandlers.h clean-local: rm -f check-version check-help lint.out

1 0

Alexander Barton : Don't ignore "permission denied" errors when enabling chroot
by alex＠arthur.barton.de 28 Mär '12

28 Mär '12

Module: ngircd.git Branch: master Commit: 88c3d4896af6c09de5d360d93ad8b02793aeb234 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=88c3d489… Author: Alexander Barton <alex(a)barton.de> Date: Wed Mar 28 11:30:48 2012 +0200 Don't ignore "permission denied" errors when enabling chroot Up to now, ngIRCd silently ignored permission denied errors when trying to enable a chroot setup: only the "not running chrooted" message became logged later on. This patch lets ngIRCd exit with a fatal error when the chroot can't be enabled on startup -- this is the much safer bevahiour! --- src/ngircd/ngircd.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c index 60d15a1..f28ff05 100644 --- a/src/ngircd/ngircd.c +++ b/src/ngircd/ngircd.c @@ -642,12 +642,10 @@ NGIRCd_Init(bool NGIRCd_NoDaemon) } if (chroot(Conf_Chroot) != 0) { - if (errno != EPERM) { - Log(LOG_ERR, - "Can't change root directory to \"%s\": %s", - Conf_Chroot, strerror(errno)); - goto out; - } + Log(LOG_ERR, + "Can't change root directory to \"%s\": %s", + Conf_Chroot, strerror(errno)); + goto out; } else { chrooted = true; Log(LOG_INFO,

1 0

Alexander Barton : FAQ: enhance description of chroot setup
by alex＠arthur.barton.de 28 Mär '12

28 Mär '12

Module: ngircd.git Branch: master Commit: 7b6ef3bc8eef8a084bc77155e4cd64a35198aad9 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=7b6ef3bc… Author: Alexander Barton <alex(a)barton.de> Date: Wed Mar 28 11:29:26 2012 +0200 FAQ: enhance description of chroot setup --- doc/FAQ.txt | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/FAQ.txt b/doc/FAQ.txt index b7a1c94..fe8510b 100644 --- a/doc/FAQ.txt +++ b/doc/FAQ.txt @@ -64,11 +64,19 @@ A: ngIRCd does not write its own log file. Instead, ngIRCd uses syslog(3). Q: I cannot connect to remote peers when I use the chroot option, the following is logged: "Can't resolve example.com: unknown error!". +A: see next question blow ... + +Q: When running ngIRCd inside a chroot, no IP addresses can be translated + in DNS names, errors like "Name or service not known" are logged. A: On Linux/glibc with chroot enabled you need to put some libraries inside the chroot as well, notably libnss_dns; maybe others. Unfortunately, even - linking ngIRCd statically does not help this. The only known workaround - is to either disable chroot support or to link against dietlibc instead - of glibc. (tnx to Sebastian Siewior) + linking ngIRCd statically does not help this. So you can either copy + all the required files into the chroot directory: + $ mkdir -p ./chroot/etc ./chroot/lib + $ cp -a /etc/hosts /etc/resolv.conf /etc/nsswitch.conf ./chroot/etc/ + $ cp -a /lib/libresolv* /lib/libnss_* ./chroot/lib/ + Or you can try to link ngIRCd against an other C library (like dietlibc) + that doesn't depend on NSS modules and/or these files. Q: I have added an [Oper] section, how do i log on as IRC operator? A: You can use the /OPER command in your IRC client to become an IRC operator.

1 0

Alexander Barton : ngIRCd Release 19.1
by alex＠arthur.barton.de 19 Mär '12

19 Mär '12

Module: ngircd.git Branch: master Commit: fbaa751da824d0dd2a58086d2cec860cc88afa1d URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=fbaa751d… Author: Alexander Barton <alex(a)barton.de> Date: Mon Mar 19 19:19:58 2012 +0100 ngIRCd Release 19.1 --- ChangeLog | 2 +- NEWS | 2 +- contrib/Debian/changelog | 6 ++++++ contrib/ngircd.spec | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index ad80a66..5892b16 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,7 +9,7 @@ -- ChangeLog -- -ngIRCd Release 19.1 +ngIRCd Release 19.1 (2012-03-19) - Fix gcc warning (v4.6.3), initialize "list" variable to NULL. - Fix typos: "recieved" -> "received", "Please not" -> "Please note", diff --git a/NEWS b/NEWS index 6db2d67..4530de1 100644 --- a/NEWS +++ b/NEWS @@ -9,7 +9,7 @@ -- NEWS -- -ngIRCd Release 19.1 +ngIRCd Release 19.1 (2012-03-19) - Really include _all_ patchtes to build the Anope module into the distribution archive ... ooops! diff --git a/contrib/Debian/changelog b/contrib/Debian/changelog index 205e382..0df0a2e 100644 --- a/contrib/Debian/changelog +++ b/contrib/Debian/changelog @@ -1,3 +1,9 @@ +ngircd (19.1-0ab1) unstable; urgency=low + + * New "upstream" release: ngIRCd 19.1. + + -- Alexander Barton <alex(a)barton.de> Mon, 19 Mar 2012 19:18:28 +0100 + ngircd (19-0ab1) unstable; urgency=low * New "upstream" release: ngIRCd 19. diff --git a/contrib/ngircd.spec b/contrib/ngircd.spec index e1d5d12..122c56f 100644 --- a/contrib/ngircd.spec +++ b/contrib/ngircd.spec @@ -1,5 +1,5 @@ %define name ngircd -%define version 19 +%define version 19.1 %define release 1 %define prefix %{_prefix}

1 0

Tag rel-19.1: Alexander Barton : ngIRCd Release 19.1
by alex＠arthur.barton.de 19 Mär '12

19 Mär '12

Module: ngircd.git Branch: refs/tags/rel-19.1 Tag: 7c7cfeb7bd35ace16aa3c118eed756a309da94aa URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=tag;h=7c7cfeb7bd3… Tagger: Alexander Barton <alex(a)barton.de> Date: Mon Mar 19 19:20:11 2012 +0100 ngIRCd Release 19.1

1 0

Alexander Barton : Update ChangeLog for upcoming ngIRCd 19.1 release
by alex＠arthur.barton.de 16 Mär '12

16 Mär '12

Module: ngircd.git Branch: master Commit: 06b63278754464792529ee0594dc218fa02b4c44 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=06b63278… Author: Alexander Barton <alex(a)barton.de> Date: Fri Mar 16 13:55:00 2012 +0100 Update ChangeLog for upcoming ngIRCd 19.1 release --- ChangeLog | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3246ef5..ad80a66 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,9 @@ ngIRCd Release 19.1 + - Fix gcc warning (v4.6.3), initialize "list" variable to NULL. + - Fix typos: "recieved" -> "received", "Please not" -> "Please note", + and fix lintian(1) warning ""hyphen-used-as-minus-sign", too. - Really include _all_ patchtes to build the Anope module into the distribution archive ... ooops! - getpid.sh: Fix testcase error for Debian using sbuild(1).

1 0

Alexander Barton : Fix gcc warning, initialize "list" variable to NULL
by alex＠arthur.barton.de 12 Mär '12

12 Mär '12

Module: ngircd.git Branch: master Commit: 0d9740b9fa1a432d35f73fafa7fb2ecd9a435502 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=0d9740b9… Author: Alexander Barton <alex(a)barton.de> Date: Mon Mar 12 22:27:55 2012 +0100 Fix gcc warning, initialize "list" variable to NULL This fixes the following warning with gcc 4.6.3.: irc-mode.c: In function "Channel_Mode": irc-mode.c:947:26: error: "list" may be used uninitialized in this function irc-mode.c:884:25: error: "list" may be used uninitialized in this function (The variable has never been used uninitialized, so don't worry) --- src/ngircd/irc-mode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c index 80b2949..fa35cdd 100644 --- a/src/ngircd/irc-mode.c +++ b/src/ngircd/irc-mode.c @@ -856,7 +856,7 @@ Add_To_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel, const char *Pattern) { const char *mask; - struct list_head *list; + struct list_head *list = NULL; long int current_count; assert(Client != NULL); @@ -923,7 +923,7 @@ Del_From_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel, const char *Pattern) { const char *mask; - struct list_head *list; + struct list_head *list = NULL; assert(Client != NULL); assert(Channel != NULL);

1 0