March 2015 - ngIRCd GIT Updates

Alexander Barton : Fix spelling of RPL_WHOISBOT message text
by alex＠arthur.barton.de 27 Mar '15

27 Mar '15

Module: ngircd.git Branch: master Commit: c7bbc9a39095344156a5e9871329b418cca72088 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=c7bbc9a3… Author: Alexander Barton <alex(a)barton.de> Date: Fri Mar 27 22:51:21 2015 +0100 Fix spelling of RPL_WHOISBOT message text --- src/ngircd/messages.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/messages.h b/src/ngircd/messages.h index 0115a06..75c67b0 100644 --- a/src/ngircd/messages.h +++ b/src/ngircd/messages.h @@ -75,7 +75,7 @@ #define RPL_NOTOPIC_MSG "331 %s %s :No topic is set" #define RPL_TOPIC_MSG "332 %s %s :%s" #define RPL_TOPICSETBY_MSG "333 %s %s %s %u" -#define RPL_WHOISBOT_MSG "335 %s %s :is a IRC Bot" +#define RPL_WHOISBOT_MSG "335 %s %s :is an IRC Bot" #define RPL_INVITING_MSG "341 %s %s %s%s" #define RPL_INVITELIST_MSG "346 %s %s %s" #define RPL_ENDOFINVITELIST_MSG "347 %s %s :End of channel invite list"

1 0

Alexander Barton : Don't send nick name as default PART reason
by alex＠arthur.barton.de 14 Mar '15

14 Mar '15

Module: ngircd.git Branch: master Commit: 6171beb7ab5dc0586581660852576f437470df63 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=6171beb7… Author: Alexander Barton <alex(a)barton.de> Date: Sat Mar 14 11:13:50 2015 +0100 Don't send nick name as default PART reason No other IRC daemon seems to do this (today?), don't remember why ngIRCd did it in the first place ... Closes #185. Reported by Cahata in #ngircd, thanks! --- src/ngircd/irc-channel.c | 4 ++-- src/testsuite/channel-test.e | 8 ++++---- src/testsuite/invite-test.e | 2 +- src/testsuite/who-test.e | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/ngircd/irc-channel.c b/src/ngircd/irc-channel.c index c142243..aa4abe3 100644 --- a/src/ngircd/irc-channel.c +++ b/src/ngircd/irc-channel.c @@ -1,6 +1,6 @@ /* * ngIRCd -- The Next Generation IRC Daemon - * Copyright (c)2001-2014 Alexander Barton (alex(a)barton.de) and Contributors. + * Copyright (c)2001-2015 Alexander Barton (alex(a)barton.de) and Contributors. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -448,7 +448,7 @@ IRC_PART(CLIENT * Client, REQUEST * Req) while (chan) { Channel_Part(target, Client, chan, - Req->argc > 1 ? Req->argv[1] : Client_ID(target)); + Req->argc > 1 ? Req->argv[1] : ""); chan = strtok(NULL, ","); } diff --git a/src/testsuite/channel-test.e b/src/testsuite/channel-test.e index 39ad16a..f65c519 100644 --- a/src/testsuite/channel-test.e +++ b/src/testsuite/channel-test.e @@ -64,10 +64,10 @@ expect { "323 nick :End of LIST" } -send "part #channel\r" +send "part #channel :bye bye\r" expect { timeout { exit 1 } - "@* PART #channel :nick" + "@* PART #channel :bye bye" } send "join #channel\r" @@ -93,11 +93,11 @@ expect { send "join 0\r" expect { timeout { exit 1 } - "@* PART #channel2 :nick" + "@* PART #channel2 :" } expect { timeout { exit 1 } - "@* PART #channel :nick" + "@* PART #channel :" } send "quit\r" diff --git a/src/testsuite/invite-test.e b/src/testsuite/invite-test.e index 5179d8a..b9e0c3f 100644 --- a/src/testsuite/invite-test.e +++ b/src/testsuite/invite-test.e @@ -82,7 +82,7 @@ expect { send "part #channel\r" expect { timeout { exit 1} - -re "PART #channel :?nick" + "@* PART #channel :" } send "invite nick :parameter with spaces\r" diff --git a/src/testsuite/who-test.e b/src/testsuite/who-test.e index 39d50ed..39e3a2f 100644 --- a/src/testsuite/who-test.e +++ b/src/testsuite/who-test.e @@ -89,7 +89,7 @@ expect { send "part #channel\r" expect { timeout { exit 1 } - "@* PART #channel :nick" + "@* PART #channel :" } send "who Real?Name\r"

1 0

Alexander Barton : Fix "WHO #<chan>" showing invisible users and hiding all visible
by alex＠arthur.barton.de 14 Mar '15

14 Mar '15

Module: ngircd.git Branch: master Commit: 2196e945e4ac5f41d6650c4ceb9120cfd8fc8d56 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=2196e945… Author: Alexander Barton <alex(a)barton.de> Date: Thu Mar 12 00:28:31 2015 +0100 Fix "WHO #<chan>" showing invisible users and hiding all visible The logic is reversed ... This bug has been introduced by commit c74115f2, "Simplify mode checking on channels and users within a channel", ngIRCd releases 21, 21.1, and 22 are affected :-( Problem reported by Cahata in #ngircd, Thanks! --- src/ngircd/irc-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c index 763c930..61c6239 100644 --- a/src/ngircd/irc-info.c +++ b/src/ngircd/irc-info.c @@ -162,7 +162,7 @@ IRC_WHO_Channel(CLIENT *Client, CHANNEL *Chan, bool OnlyOps) if (OnlyOps && !is_ircop) continue; - is_visible = Client_HasMode(c, 'i'); + is_visible = !Client_HasMode(c, 'i'); if (is_member || is_visible) { memset(flags, 0, sizeof(flags));

1 0

Alexander Barton : Fix typo in src/testsuite/README
by alex＠arthur.barton.de 11 Mar '15

11 Mar '15

Module: ngircd.git Branch: master Commit: f16eb1b686ab3cd3c0b313ef6853dce3ee129677 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=f16eb1b6… Author: Alexander Barton <alex(a)barton.de> Date: Wed Mar 11 22:14:24 2015 +0100 Fix typo in src/testsuite/README --- src/testsuite/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testsuite/README b/src/testsuite/README index c8a3917..4ff5ea9 100644 --- a/src/testsuite/README +++ b/src/testsuite/README @@ -50,7 +50,7 @@ start-server.sh [<id>] and that no other instance of the test binary is already running. The exit code is 0 if the test binary could be started. -stop-server.sha [<id>] +stop-server.sh [<id>] This script uses getpid.sh to detect a running test binary "T-ngircd<id>" and then shuts it down using the TERM signal.

1 0