Januar 2012 - ngIRCd GIT Updates

Alexander Barton : Update NEWS and ChangeLog files
by alex＠arthur.barton.de 23 Jan '12

23 Jan '12

Module: ngircd.git Branch: master Commit: 8c46067b34b71dac23b388c0acc28fdf8db111fa URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=8c46067b… Author: Alexander Barton <alex(a)barton.de> Date: Mon Jan 23 12:30:16 2012 +0100 Update NEWS and ChangeLog files --- ChangeLog | 7 +++++++ NEWS | 7 +++++++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index ca83f29..b7083db 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,9 @@ ngIRCd Release 19 + - New numeric RPL_WHOISHOST_MSG(378), which returns the DNS hostname + (if available) and the IP address of a client in the WHOIS reply. + Only the user itself and local IRC operators get this numeric. - Implement channel exception list (mode 'e'). This allows a channel operator to define exception masks that allow users to join the channel even when a "ban" would match and prevent them from joining: @@ -86,6 +89,10 @@ ngIRCd Release 19 - Log better error messages when rejecting clients. - Implement IRC commands "GLINE" and "KLINE" to ban users. G-Lines are synchronized between server on peering, K-Lines are local only. + If you use "*!<user>@<host>" or "*!*@<host>" masks, these connections + are blocked even before the user is fully logged in (before PASS, + NICK, and USER commands have been processed) and before the child + processes for authentication are forked, so resource usage is smaller. - Xcode: update project file for Xcode 4.2 and define HAVE_GAI_STRERROR for Mac OS X Xcode builds. - ./configure: Fix logic and quoting of poll() detection code: only use diff --git a/NEWS b/NEWS index 14bbe79..054780e 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,9 @@ ngIRCd Release 19 + - New numeric RPL_WHOISHOST_MSG(378), which returns the DNS hostname + (if available) and the IP address of a client in the WHOIS reply. + Only the user itself and local IRC operators get this numeric. - Implement channel exception list (mode 'e'). This allows a channel operator to define exception masks that allow users to join the channel even when a "ban" would match and prevent them from joining: @@ -50,6 +53,10 @@ ngIRCd Release 19 Reported by Cahata, thanks! - Implement IRC commands "GLINE" and "KLINE" to ban users. G-Lines are synchronized between server on peering, K-Lines are local only. + If you use "*!<user>@<host>" or "*!*@<host>" masks, these connections + are blocked even before the user is fully logged in (before PASS, + NICK, and USER commands have been processed) and before the child + processes for authentication are forked, so resource usage is smaller. - Added doc/Modes.txt: document modes supported by ngIRCd. - Implement user mode "R": indicates that the nick name of this user is "registered". This mode isn't handled by ngIRCd itself, but must

1 0

Alexander Barton : New RPL_WHOISHOST_MSG(378): show hostname and IP address
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 594fdd02aaa482b8273a8d24aa48510ecf0981ba URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=594fdd02… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 22:41:39 2012 +0100 New RPL_WHOISHOST_MSG(378): show hostname and IP address The numeric RPL_WHOISHOST_MSG(378) returns the DNS hostname (if available) and the IP address of a client in the WHOIS reply. Only the user itself and local IRC operators get this numeric. --- src/ngircd/irc-info.c | 6 ++++++ src/ngircd/messages.h | 1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c index 93c43b7..841e6e6 100644 --- a/src/ngircd/irc-info.c +++ b/src/ngircd/irc-info.c @@ -1114,6 +1114,12 @@ IRC_WHOIS_SendReply(CLIENT *Client, CLIENT *from, CLIENT *c) Client_ID(from), Client_ID(c))) return DISCONNECTED; + if (Client_Conn(c) > NONE && (Client_OperByMe(from) || from == c) && + !IRC_WriteStrClient(from, RPL_WHOISHOST_MSG, Client_ID(from), + Client_ID(c), Client_Hostname(c), + Conn_GetIPAInfo(Client_Conn(c)))) + return DISCONNECTED; + /* Idle and signon time (local clients only!) */ if (!Conf_MorePrivacy && Client_Conn(c) > NONE && !IRC_WriteStrClient(from, RPL_WHOISIDLE_MSG, diff --git a/src/ngircd/messages.h b/src/ngircd/messages.h index 340f5f4..f059077 100644 --- a/src/ngircd/messages.h +++ b/src/ngircd/messages.h @@ -91,6 +91,7 @@ #define RPL_MOTD_MSG "372 %s :- %s" #define RPL_MOTDSTART_MSG "375 %s :- %s message of the day" #define RPL_ENDOFMOTD_MSG "376 %s :End of MOTD command" +#define RPL_WHOISHOST_MSG "378 %s %s :is connecting from *@%s %s" #define RPL_YOUREOPER_MSG "381 %s :You are now an IRC Operator" #define RPL_YOURESERVICE_MSG "383 %s :You are service %s" #define RPL_TIME_MSG "391 %s %s :%s"

1 0

Alexander Barton : New function Conn_GetIPAInfo(): get IP address of a connection
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 6a308fcb42eae1de168699ed432b49b610073ede URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=6a308fcb… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 22:35:27 2012 +0100 New function Conn_GetIPAInfo(): get IP address of a connection --- src/ngircd/conn.c | 14 ++++++++++++++ src/ngircd/conn.h | 2 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c index 40a2af6..35d7400 100644 --- a/src/ngircd/conn.c +++ b/src/ngircd/conn.c @@ -1227,6 +1227,20 @@ Conn_SyncServerStruct(void) /** + * Get IP address string of a connection. + * + * @param Idx Connection index. + * @return Pointer to a global buffer containing the IP address as string. + */ +GLOBAL const char * +Conn_GetIPAInfo(CONN_ID Idx) +{ + assert(Idx > NONE); + return ng_ipaddr_tostr(&My_Connections[Idx].addr); +} + + +/** * Send out data of write buffer; connect new sockets. * * @param Idx Connection index. diff --git a/src/ngircd/conn.h b/src/ngircd/conn.h index 251da2a..4752ec1 100644 --- a/src/ngircd/conn.h +++ b/src/ngircd/conn.h @@ -131,6 +131,8 @@ Conn_UsesSSL(UNUSED CONN_ID Idx) { return false; } #endif +GLOBAL const char *Conn_GetIPAInfo PARAMS((CONN_ID Idx)); + GLOBAL long Conn_Count PARAMS((void)); GLOBAL long Conn_CountMax PARAMS((void)); GLOBAL long Conn_CountAccepted PARAMS((void));

1 0

Alexander Barton : G/K-Lines: only add and delete valid IRC masks
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 1537c791320086df83b8fbecb057e70c7120ea12 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=1537c791… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 18:53:16 2012 +0100 G/K-Lines: only add and delete valid IRC masks --- src/ngircd/class.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ngircd/class.c b/src/ngircd/class.c index 0a8ae24..0f617b8 100644 --- a/src/ngircd/class.c +++ b/src/ngircd/class.c @@ -112,7 +112,8 @@ Class_AddMask(const int Class, const char *Mask, time_t ValidUntil, assert(Mask != NULL); assert(Reason != NULL); - return Lists_Add(&My_Classes[Class], Mask, ValidUntil, Reason); + return Lists_Add(&My_Classes[Class], Lists_MakeMask(Mask), + ValidUntil, Reason); } GLOBAL void @@ -121,7 +122,7 @@ Class_DeleteMask(const int Class, const char *Mask) assert(Class < CLASS_COUNT); assert(Mask != NULL); - Lists_Del(&My_Classes[Class], Mask); + Lists_Del(&My_Classes[Class], Lists_MakeMask(Mask)); } GLOBAL struct list_head *

1 0

Alexander Barton : Streamline handling of connection rejects (bad password, G/K-line)
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: eba95bb0d240aa3c8791cb6eb830ced5023db0b0 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=eba95bb0… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 18:33:45 2012 +0100 Streamline handling of connection rejects (bad password, G/K-line) - Use Client_Reject(), get rid of Reject_Client(). - Refactor Class_IsMember() to Class_GetMemberReason(), - New function Class_HandleServerBans(). --- src/ngircd/class.c | 57 ++++++++++++++++++++++++++++++++++++++++++++--- src/ngircd/class.h | 5 ++- src/ngircd/irc-login.c | 38 ++++++-------------------------- 3 files changed, 63 insertions(+), 37 deletions(-) diff --git a/src/ngircd/class.c b/src/ngircd/class.c index b7a5cbc..0a8ae24 100644 --- a/src/ngircd/class.c +++ b/src/ngircd/class.c @@ -1,6 +1,6 @@ /* * ngIRCd -- The Next Generation IRC Daemon - * Copyright (c)2001-2011 Alexander Barton (alex(a)barton.de) and Contributors. + * Copyright (c)2001-2012 Alexander Barton (alex(a)barton.de) and Contributors. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -26,12 +26,15 @@ #include "client.h" #include "lists.h" #include "match.h" +#include "stdio.h" #include "exp.h" #include "class.h" struct list_head My_Classes[CLASS_COUNT]; +char Reject_Reason[COMMAND_LEN]; + GLOBAL void Class_Init(void) { @@ -46,15 +49,61 @@ Class_Exit(void) for (i = 0; i < CLASS_COUNT; Lists_Free(&My_Classes[i++])); } -GLOBAL bool -Class_IsMember(const int Class, CLIENT *Client) +GLOBAL char * +Class_GetMemberReason(const int Class, CLIENT *Client) { + char *reason; + assert(Class < CLASS_COUNT); assert(Client != NULL); - return Lists_Check(&My_Classes[Class], Client); + reason = Lists_CheckReason(&My_Classes[Class], Client); + if (!reason) + return NULL; + + if (!*reason) + reason = "listed"; + + switch(Class) { + case CLASS_GLINE: + snprintf(Reject_Reason, sizeof(Reject_Reason), + "\"%s\" (G-Line)", reason); + return Reject_Reason; + case CLASS_KLINE: + snprintf(Reject_Reason, sizeof(Reject_Reason), + "\"%s\" (K-Line)", reason); + return Reject_Reason; + } + return reason; +} + +/** + * Check if a client is banned from this server: GLINE, KLINE. + * + * If a client isn't allowed to connect, it will be disconnected again. + * + * @param Client The client to check. + * @return CONNECTED if client is allowed to join, DISCONNECTED if not. + */ +GLOBAL bool +Class_HandleServerBans(CLIENT *Client) +{ + char *rejectptr; + + assert(Client != NULL); + + rejectptr = Class_GetMemberReason(CLASS_GLINE, Client); + if (!rejectptr) + rejectptr = Class_GetMemberReason(CLASS_KLINE, Client); + if (rejectptr) { + Client_Reject(Client, rejectptr, true); + return DISCONNECTED; + } + + return CONNECTED; } + GLOBAL bool Class_AddMask(const int Class, const char *Mask, time_t ValidUntil, const char *Reason) diff --git a/src/ngircd/class.h b/src/ngircd/class.h index 8c06c2e..2a9dbba 100644 --- a/src/ngircd/class.h +++ b/src/ngircd/class.h @@ -1,6 +1,6 @@ /* * ngIRCd -- The Next Generation IRC Daemon - * Copyright (c)2001-2011 Alexander Barton (alex(a)barton.de) and Contributors. + * Copyright (c)2001-2012 Alexander Barton (alex(a)barton.de) and Contributors. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -29,7 +29,8 @@ GLOBAL bool Class_AddMask PARAMS((const int Class, const char *Mask, const time_t ValidUntil, const char *Reason)); GLOBAL void Class_DeleteMask PARAMS((const int Class, const char *Mask)); -GLOBAL bool Class_IsMember PARAMS((const int Class, CLIENT *Client)); +GLOBAL char *Class_GetMemberReason PARAMS((const int Class, CLIENT *Client)); +GLOBAL bool Class_HandleServerBans PARAMS((CLIENT *Client)); GLOBAL struct list_head *Class_GetList PARAMS((const int Class)); diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c index bbb2f0d..54818fe 100644 --- a/src/ngircd/irc-login.c +++ b/src/ngircd/irc-login.c @@ -47,7 +47,6 @@ static bool Hello_User PARAMS(( CLIENT *Client )); static bool Hello_User_PostAuth PARAMS(( CLIENT *Client )); static void Kill_Nick PARAMS(( char *Nick, char *Reason )); static void Introduce_Client PARAMS((CLIENT *To, CLIENT *Client, int Type)); -static void Reject_Client PARAMS((CLIENT *Client, const char *InternalReason)); static void cb_introduceClient PARAMS((CLIENT *Client, CLIENT *Prefix, void *i)); @@ -945,7 +944,7 @@ Hello_User(CLIENT * Client) * passwords supplied are classified as "wrong". */ if(Client_Password(Client)[0] == '\0') return Hello_User_PostAuth(Client); - Reject_Client(Client, "non-empty password"); + Client_Reject(Client, "Non-empty password", false); return DISCONNECTED; } @@ -981,7 +980,7 @@ Hello_User(CLIENT * Client) /* Check global server password ... */ if (strcmp(Client_Password(Client), Conf_ServerPwd) != 0) { /* Bad password! */ - Reject_Client(Client, "bad server password"); + Client_Reject(Client, "Bad server password", false); return DISCONNECTED; } return Hello_User_PostAuth(Client); @@ -1026,7 +1025,7 @@ cb_Read_Auth_Result(int r_fd, UNUSED short events) if (len != sizeof(result)) { Log(LOG_CRIT, "Auth: Got malformed result!"); - Reject_Client(client, "internal error"); + Client_Reject(client, "Internal error", false); return; } @@ -1034,32 +1033,13 @@ cb_Read_Auth_Result(int r_fd, UNUSED short events) Client_SetUser(client, Client_OrigUser(client), true); (void)Hello_User_PostAuth(client); } else - Reject_Client(client, "bad password"); + Client_Reject(client, "Bad password", false); } #endif /** - * Reject a client because of wrong password. - * - * This function is called either when the global server password or a password - * checked using PAM has been wrong. - * - * @param Client The client to reject. - */ -static void -Reject_Client(CLIENT *Client, const char *InternalReason) -{ - Log(LOG_ERR, - "User \"%s\" rejected (connection %d): %s!", - Client_Mask(Client), Client_Conn(Client), InternalReason); - Conn_Close(Client_Conn(Client), InternalReason, - "Access denied! Bad password?", true); -} - - -/** * Finish client registration. * * Introduce the new client to the network and send all "hello messages" @@ -1071,14 +1051,10 @@ Reject_Client(CLIENT *Client, const char *InternalReason) static bool Hello_User_PostAuth(CLIENT *Client) { - if (Class_IsMember(CLASS_GLINE, Client)) { - Reject_Client(Client, "G-Line'd"); - return DISCONNECTED; - } - if (Class_IsMember(CLASS_KLINE, Client)) { - Reject_Client(Client, "K-Line'd"); + assert(Client != NULL); + + if (Class_HandleServerBans(Client) != CONNECTED) return DISCONNECTED; - } Introduce_Client(NULL, Client, CLIENT_USER);

1 0

Alexander Barton : Check G/K-Lines before the client has been registered, too
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: e0c9931ad8db8a9bd7d6c030d856ccc28c6facc2 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=e0c9931a… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 18:35:54 2012 +0100 Check G/K-Lines before the client has been registered, too This allows to use "*!<user>@<host>" or "*!*@<host>" masks to reject clients even before receiving PASS, NICK and USER commands and before forking authentication child processes which reduces resource usage. --- src/ngircd/conn.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c index 5f3c18a..40a2af6 100644 --- a/src/ngircd/conn.c +++ b/src/ngircd/conn.c @@ -2225,6 +2225,7 @@ cb_Read_Resolver_Result( int r_fd, UNUSED short events ) "NOTICE AUTH :*** No ident response"); } #endif + Class_HandleServerBans(c); } #ifdef DEBUG else Log( LOG_DEBUG, "Resolver: discarding result for already registered connection %d.", i );

1 0

Alexander Barton : New function Lists_CheckReason() to get reason of list entries
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 6e28f4a7d13a81db99196da23958e81f2bb8418e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=6e28f4a7… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 18:11:24 2012 +0100 New function Lists_CheckReason() to get reason of list entries --- src/ngircd/lists.c | 19 ++++++++++++++++--- src/ngircd/lists.h | 1 + 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/ngircd/lists.c b/src/ngircd/lists.c index c082f1c..4f57ca7 100644 --- a/src/ngircd/lists.c +++ b/src/ngircd/lists.c @@ -320,7 +320,20 @@ Lists_MakeMask(const char *Pattern) * @return true if client is listed, false if not. */ bool -Lists_Check( struct list_head *h, CLIENT *Client) +Lists_Check(struct list_head *h, CLIENT *Client) +{ + return Lists_CheckReason(h, Client) != NULL; +} + +/** + * Check if a client is listed in a list and return the "reason". + * + * @param h List head. + * @param Client Client to check. + * @return true if client is listed, false if not. + */ +char * +Lists_CheckReason(struct list_head *h, CLIENT *Client) { struct list_elem *e, *last, *next; @@ -338,13 +351,13 @@ Lists_Check( struct list_head *h, CLIENT *Client) e->mask); Lists_Unlink(h, last, e); } - return true; + return e->reason ? e->reason : ""; } last = e; e = next; } - return false; + return NULL; } /** diff --git a/src/ngircd/lists.h b/src/ngircd/lists.h index cb2e2c1..24504df 100644 --- a/src/ngircd/lists.h +++ b/src/ngircd/lists.h @@ -30,6 +30,7 @@ GLOBAL struct list_elem *Lists_GetFirst PARAMS((const struct list_head *)); GLOBAL struct list_elem *Lists_GetNext PARAMS((const struct list_elem *)); GLOBAL bool Lists_Check PARAMS((struct list_head *head, CLIENT *client)); +GLOBAL char *Lists_CheckReason PARAMS((struct list_head *head, CLIENT *client)); GLOBAL struct list_elem *Lists_CheckDupeMask PARAMS((const struct list_head *head, const char *mask));

1 0

Alexander Barton : New function Client_Reject() to reject clients on connect
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 51a6a33056486c19da6b8d6e4809dde57be00ece URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=51a6a330… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 18:17:28 2012 +0100 New function Client_Reject() to reject clients on connect --- src/ngircd/client.c | 33 +++++++++++++++++++++++++++++++++ src/ngircd/client.h | 3 +++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/ngircd/client.c b/src/ngircd/client.c index d1f751d..1aaf687 100644 --- a/src/ngircd/client.c +++ b/src/ngircd/client.c @@ -1097,6 +1097,39 @@ Client_StartTime(CLIENT *Client) } /* Client_Uptime */ +/** + * Reject a client when logging in. + * + * This function is called when a client isn't allowed to connect to this + * server. Possible reasons are bad server password, bad PAM password, + * or that the client is G/K-Line'd. + * + * After calling this function, the client isn't connected any more. + * + * @param Client The client to reject. + * @param Reason The reason why the client has been rejected. + * @param InformClient If true, send the exact reason to the client. + */ +GLOBAL void +Client_Reject(CLIENT *Client, const char *Reason, bool InformClient) +{ + char info[COMMAND_LEN]; + + assert(Client != NULL); + assert(Reason != NULL); + + if (InformClient) + snprintf(info, sizeof(info), "Access denied: %s", Reason); + else + strcpy(info, "Access denied: Bad password?"); + + Log(LOG_ERR, + "User \"%s\" rejected (connection %d): %s!", + Client_Mask(Client), Client_Conn(Client), Reason); + Conn_Close(Client_Conn(Client), Reason, info, true); +} + + static unsigned long Count( CLIENT_TYPE Type ) { diff --git a/src/ngircd/client.h b/src/ngircd/client.h index fecf5d9..7bb230b 100644 --- a/src/ngircd/client.h +++ b/src/ngircd/client.h @@ -163,6 +163,9 @@ GLOBAL void Client_RegisterWhowas PARAMS(( CLIENT *Client )); GLOBAL const char *Client_TypeText PARAMS((CLIENT *Client)); +GLOBAL void Client_Reject PARAMS((CLIENT *Client, const char *Reason, + bool InformClient)); + #ifdef DEBUG GLOBAL void Client_DebugDump PARAMS((void)); #endif

1 0

Alexander Barton : Update NEWS and ChangeLog files
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 9882e578e9cbb9d86d235b45938fa57bf1e85e54 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=9882e578… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 15:58:39 2012 +0100 Update NEWS and ChangeLog files --- ChangeLog | 17 ++++++++++++++++- NEWS | 26 +++++++++++++------------- 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3d7606b..ca83f29 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,7 +2,7 @@ ngIRCd - Next Generation IRC Server http://ngircd.barton.de/ - (c)2001-2011 Alexander Barton and Contributors. + (c)2001-2012 Alexander Barton and Contributors. ngIRCd is free software and published under the terms of the GNU General Public License. @@ -11,6 +11,21 @@ ngIRCd Release 19 + - Implement channel exception list (mode 'e'). This allows a channel + operator to define exception masks that allow users to join the + channel even when a "ban" would match and prevent them from joining: + the exception list (e) overrides the ban list (b). + - PRIVMSG and NOTICE: Handle nick!user@host masks case-insensitive. + - Implement user mode 'C': If the target user of a PRIVMSG or NOTICE + command has the user mode 'C' set, it is required that both sender + and receiver are on the same channel. This prevents private flooding + by completely unknown clients. + - New RPL_WHOISREGNICK_MSG(307) numeric in WHOIS command replies: it + indicates if a nick name is registered (if user mode 'R' set). + - Limit channel invite, ban, and exception lists to 50 entries and fix + duplicate check and error messages when adding already listed entries + or deleting no (longer) existing ones. + - Fix both ERR_SUMMONDISABLED(445) and ERR_USERSDISABLED(446) replies. - MODE command: correctly return ERR_UNKNOWNMODE(472) numeric for unknown channel modes, instead of ERR_UMODEUNKNOWNFLAG(501). - ISUPPORT(005) numeric: add "O", "R", and "z" modes to "CHANMODES". diff --git a/NEWS b/NEWS index 523db0f..14bbe79 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,19 @@ ngIRCd Release 19 + - Implement channel exception list (mode 'e'). This allows a channel + operator to define exception masks that allow users to join the + channel even when a "ban" would match and prevent them from joining: + the exception list (e) overrides the ban list (b). + - Implement user mode 'C': If the target user of a PRIVMSG or NOTICE + command has the user mode 'C' set, it is required that both sender + and receiver are on the same channel. This prevents private flooding + by completely unknown clients. + - New RPL_WHOISREGNICK_MSG(307) numeric in WHOIS command replies: it + indicates if a nick name is registered (if user mode 'R' set). + - Limit channel invite, ban, and exception lists to 50 entries and fix + duplicate check and error messages when adding already listed entries + or deleting no (longer) existing ones. - Limit the number of list items in the reply of LIST (100), WHO (25), WHOIS (10), and WHOWAS (25) commands. - Limit the MODE command to handle a maximum number of 5 channel modes @@ -37,12 +50,6 @@ ngIRCd Release 19 Reported by Cahata, thanks! - Implement IRC commands "GLINE" and "KLINE" to ban users. G-Lines are synchronized between server on peering, K-Lines are local only. - - Xcode: update project file for Xcode 4.2. - - Only close "unrelated" sockets in forked child processes: This fixes - the problem that ngIRCd can't do any IDENT lookups because of the - socket has already been closed in the child process. - The bug has been introduced starting with ngIRCd 17 ... :-( - (commit ID 6ebb31ab35e) - Added doc/Modes.txt: document modes supported by ngIRCd. - Implement user mode "R": indicates that the nick name of this user is "registered". This mode isn't handled by ngIRCd itself, but must @@ -50,9 +57,6 @@ ngIRCd Release 19 - Implement channel mode "R": only registered users (having the user mode "R" set) are allowed to join this channel. - Test suite: bind to loopback (127.0.0.1) interface only. - - Disconnect directly linked servers sending QUIT. Without this, - the server becomes removed from the network and the client list, - but the connection isn't shut down at all ... - Handle unknown user and channel modes: these modes are saved and forwarded to other servers, but ignored otherwise. - Handle channel user modes 'a', 'h', and 'q' from remote servers. @@ -517,7 +521,3 @@ ngIRCd 0.0.2, 06.01.2002 ngIRCd 0.0.1, 31.12.2001 - erste oeffentliche Version von ngIRCd als "public preview" :-) - - --- -$Id: NEWS,v 1.88 2008/02/26 22:05:42 fw Exp $

1 0

Alexander Barton : Fix ERR_{SUMMON|USERS}DISABLED: don' t repeat command name in reply
by alex＠arthur.barton.de 22 Jan '12

22 Jan '12

Module: ngircd.git Branch: master Commit: 73781c1b381d6b15c3d3610392deed72737d766c URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=73781c1b… Author: Alexander Barton <alex(a)barton.de> Date: Sun Jan 22 15:41:21 2012 +0100 Fix ERR_{SUMMON|USERS}DISABLED: don't repeat command name in reply --- src/ngircd/irc-info.c | 8 ++++---- src/ngircd/messages.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c index a248e8a..93c43b7 100644 --- a/src/ngircd/irc-info.c +++ b/src/ngircd/irc-info.c @@ -648,10 +648,10 @@ IRC_STATS( CLIENT *Client, REQUEST *Req ) * therefore answers with ERR_SUMMONDISABLED. */ GLOBAL bool -IRC_SUMMON(CLIENT * Client, REQUEST * Req) +IRC_SUMMON(CLIENT * Client, UNUSED REQUEST * Req) { return IRC_WriteStrClient(Client, ERR_SUMMONDISABLED_MSG, - Client_ID(Client), Req->command); + Client_ID(Client)); } /* IRC_SUMMON */ @@ -741,10 +741,10 @@ IRC_USERHOST(CLIENT *Client, REQUEST *Req) * See RFC 2812 section 4.6. As suggested there the command is disabled. */ GLOBAL bool -IRC_USERS(CLIENT * Client, REQUEST * Req) +IRC_USERS(CLIENT * Client, UNUSED REQUEST * Req) { return IRC_WriteStrClient(Client, ERR_USERSDISABLED_MSG, - Client_ID(Client), Req->command); + Client_ID(Client)); } /* IRC_USERS */ diff --git a/src/ngircd/messages.h b/src/ngircd/messages.h index 26be69a..340f5f4 100644 --- a/src/ngircd/messages.h +++ b/src/ngircd/messages.h @@ -114,8 +114,8 @@ #define ERR_USERNOTINCHANNEL_MSG "441 %s %s %s :They aren't on that channel" #define ERR_NOTONCHANNEL_MSG "442 %s %s :You are not on that channel" #define ERR_USERONCHANNEL_MSG "443 %s %s %s :is already on channel" -#define ERR_SUMMONDISABLED_MSG "445 %s %s :SUMMON has been disabled" -#define ERR_USERSDISABLED_MSG "446 %s %s :USERS has been disabled" +#define ERR_SUMMONDISABLED_MSG "445 %s :SUMMON has been disabled" +#define ERR_USERSDISABLED_MSG "446 %s :USERS has been disabled" #define ERR_NOTREGISTERED_MSG "451 %s :Connection not registered" #define ERR_NOTREGISTEREDSERVER_MSG "451 %s :Connection not registered as server link" #define ERR_NEEDMOREPARAMS_MSG "461 %s %s :Syntax error"

1 0