- ngIRCd GIT Updates - lists.barton.de

Alexander Barton : Use $(MKDIR_P) instead of $(mkinstalldirs) in Makefile's
by alex＠arthur.barton.de 17 Jan '14

17 Jan '14

Module: ngircd.git Branch: master Commit: 90062111f7fd3be5941d94781470b391bebfccaa URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=90062111… Author: Alexander Barton <alex(a)barton.de> Date: Fri Jan 17 21:04:10 2014 +0100 Use $(MKDIR_P) instead of $(mkinstalldirs) in Makefile's And test for "mkdir -p" using AC_PROG_MKDIR_P in "configure". --- configure.ng | 1 + doc/Makefile.am | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ng b/configure.ng index aec1eb1..1e141c9 100644 --- a/configure.ng +++ b/configure.ng @@ -66,6 +66,7 @@ AC_PROG_AWK AC_PROG_INSTALL AC_PROG_LN_S AC_PROG_MAKE_SET +AC_PROG_MKDIR_P AC_PROG_RANLIB # -- Compiler Features -- diff --git a/doc/Makefile.am b/doc/Makefile.am index 04f74b6..27942dd 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -54,11 +54,11 @@ maintainer-clean-local: all: $(generated_docs) install-data-hook: $(static_docs) $(toplevel_docs) $(generated_docs) - $(mkinstalldirs) $(DESTDIR)$(sysconfdir) + $(MKDIR_P) -m 755 $(DESTDIR)$(sysconfdir) @if [ ! -f $(DESTDIR)$(sysconfdir)/ngircd.conf ]; then \ make install-config; \ fi - $(mkinstalldirs) $(DESTDIR)$(docdir) + $(MKDIR_P) -m 755 $(DESTDIR)$(docdir) for f in $(static_docs) $(toplevel_docs); do \ $(INSTALL) -m 644 -c $(srcdir)/$$f $(DESTDIR)$(docdir)/; \ done

1 0

Alexander Barton : Fix configure script and "make check" for TCP Wrappers
by alex＠arthur.barton.de 17 Jan '14

17 Jan '14

Module: ngircd.git Branch: master Commit: e747fe92775f577a38f8dd681f7a58f751348f5e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=e747fe92… Author: Alexander Barton <alex(a)barton.de> Date: Fri Jan 17 16:18:55 2014 +0100 Fix configure script and "make check" for TCP Wrappers Add missing #include's and static variables. Problem spotted on OpenBSD. --- configure.ng | 2 ++ src/portab/portabtest.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configure.ng b/configure.ng index 7d22090..aec1eb1 100644 --- a/configure.ng +++ b/configure.ng @@ -470,6 +470,8 @@ AC_ARG_WITH(tcp-wrappers, LIBS="-lwrap $LIBS" LIBS_END="-lwrap $LIBS_END" AC_LINK_IFELSE([AC_LANG_PROGRAM([[ +#include <sys/types.h> +#include <sys/socket.h> #include <tcpd.h> int allow_severity = 0; int deny_severity = 0; diff --git a/src/portab/portabtest.c b/src/portab/portabtest.c index b104739..3602fee 100644 --- a/src/portab/portabtest.c +++ b/src/portab/portabtest.c @@ -24,6 +24,8 @@ #include "exp.h" +int allow_severity = 0, deny_severity = 0; + static void Panic(char *Reason) {

1 0

Alexander Barton : Add libwrap at the end of the configure run
by alex＠arthur.barton.de 17 Jan '14

17 Jan '14

Module: ngircd.git Branch: master Commit: 0f85c4c6a70a71c935af9c28e2c469ea4b66220a URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=0f85c4c6… Author: Alexander Barton <alex(a)barton.de> Date: Fri Jan 17 16:10:34 2014 +0100 Add libwrap at the end of the configure run If libwrap becomes added earlier, other tests may fail because of not all external variables required by libwrap are available when linking: for example allow_severity and deny_severity. This patch adds generic support for the LDFLAGS_END and LIBS_END variables (CFLAGS_END has been implemented already). Problem spotted on OpenBSD. --- configure.ng | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ng b/configure.ng index 0b0a658..7d22090 100644 --- a/configure.ng +++ b/configure.ng @@ -466,7 +466,9 @@ AC_ARG_WITH(tcp-wrappers, LDFLAGS="-L$withval/lib $LDFLAGS" fi AC_MSG_CHECKING(for hosts_access) + saved_LIBS="$LIBS" LIBS="-lwrap $LIBS" + LIBS_END="-lwrap $LIBS_END" AC_LINK_IFELSE([AC_LANG_PROGRAM([[ #include <tcpd.h> int allow_severity = 0; @@ -481,6 +483,7 @@ int deny_severity = 0; AC_MSG_RESULT(no) AC_MSG_ERROR([Can't enable TCP wrappers!]) ]) + LIBS="$saved_LIBS" fi ] ) @@ -636,9 +639,12 @@ AC_DEFINE_UNQUOTED(HOST_CPU, "$host_cpu" ) AC_DEFINE_UNQUOTED(HOST_VENDOR, "$host_vendor" ) AC_DEFINE_UNQUOTED(HOST_OS, "$host_os" ) -# Add additional CFLAGS, eventually specified on the command line, but after -# running this configure script. Useful for "-Werror" for example. +# Add additional CFLAGS, LDFLAGS and LIBS which were specified on the command +# line or by some tests from above, but after running this script. Useful for +# adding "-Werror", for example: test -n "$CFLAGS_END" && CFLAGS="$CFLAGS $CFLAGS_END" +test -n "$LDFLAGS_END" && LDFLAGS="$LDFLAGS $LDFLAGS_END" +test -n "$LIBS_END" && LIBS="$LIBS $LIBS_END" # -- Generate files --

1 0

Alexander Barton : platformtest.sh: Allow using separate source and build trees
by alex＠arthur.barton.de 11 Jan '14

11 Jan '14

Module: ngircd.git Branch: master Commit: 2560e5f1560b6b4a225e77de67876a588543c53d URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=2560e5f1… Author: Alexander Barton <alex(a)barton.de> Date: Sat Jan 11 01:33:24 2014 +0100 platformtest.sh: Allow using separate source and build trees Now you can call platformtest.sh using its complete path name from an other directory which is then used for building. See <http://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html> Please not that the build system itself is still (re-)genrated in the original source tree. This can be avoided by passing the "-x" switch to the platformtest.sh script. --- contrib/platformtest.sh | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/contrib/platformtest.sh b/contrib/platformtest.sh index f34a889..1067a6e 100755 --- a/contrib/platformtest.sh +++ b/contrib/platformtest.sh @@ -29,6 +29,9 @@ R_MAKE= R_CHECK= R_RUN= +SRC_D=`dirname "$0"` +MY_D="$PWD" + [ -n "$MAKE" ] || MAKE="make" export MAKE CC @@ -52,35 +55,41 @@ while [ $# -gt 0 ]; do done echo "$NAME: Checking ngIRCd base source directory ..." -grep "ngIRCd" ./ChangeLog >/dev/null 2>&1 +grep "ngIRCd" "$SRC_D/ChangeLog" >/dev/null 2>&1 if [ $? -ne 0 ]; then - grep "ngIRCd" ../ChangeLog >/dev/null 2>&1 + grep "ngIRCd" "$SRC_D/../ChangeLog" >/dev/null 2>&1 if [ $? -ne 0 ]; then echo "$NAME: ngIRCd base source directory not found!?" exit 1 fi - cd .. + SRC_D="$SRC_D/.." fi +echo "$NAME: - source directory: $SRC_D" +echo "$NAME: - working directory: $MY_D" echo "$NAME: Checking for GIT tree ..." -if [ -d .git ]; then +if [ -d "$SRC_D/.git" ]; then echo "$NAME: Checking for \"git\" command ..." git version >/dev/null 2>&1 if [ $? -eq 0 -a -n "$CLEAN" ]; then echo "$NAME: Running \"git clean\" ..." + cd "$SRC_D" || exit 1 [ -n "$VERBOSE" ] && git clean -dxf || git clean -dxf >/dev/null + cd "$MY_D" || exit 1 fi fi -echo "$NAME: Checking for \"./configure\" script ..." -if [ ! -r ./configure ]; then - echo "$NAME: Running \"./autogen.sh\" ..." +echo "$NAME: Checking for \"$SRC_D/configure\" script ..." +if [ ! -r "$SRC_D/configure" ]; then + echo "$NAME: Running \"$SRC_D/autogen.sh\" ..." + cd "$SRC_D" || exit 1 [ -n "$VERBOSE" ] && ./autogen.sh || ./autogen.sh >/dev/null + cd "$MY_D" || exit 1 fi -if [ -r ./configure ]; then - echo "$NAME: Running \"./configure\" script ..." - [ -n "$VERBOSE" ] && ./configure || ./configure >/dev/null +if [ -r "$SRC_D/configure" ]; then + echo "$NAME: Running \"$SRC_D/configure\" script ..." + [ -n "$VERBOSE" ] && "$SRC_D/configure" -C || "$SRC_D/configure" -C >/dev/null if [ $? -eq 0 -a -r ./Makefile ]; then R_CONFIGURE=1 echo "$NAME: Running \"$MAKE\" ..."

1 0

Alexander Barton : platformtest.sh: Show only up to 10 bytes of version information
by alex＠arthur.barton.de 11 Jan '14

11 Jan '14

Module: ngircd.git Branch: master Commit: 1f5508d0497f1cace5a482fcd7f50ecfce0715f7 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=1f5508d0… Author: Alexander Barton <alex(a)barton.de> Date: Sat Jan 11 01:32:12 2014 +0100 platformtest.sh: Show only up to 10 bytes of version information --- contrib/platformtest.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/platformtest.sh b/contrib/platformtest.sh index dfefc1a..f34a889 100755 --- a/contrib/platformtest.sh +++ b/contrib/platformtest.sh @@ -151,8 +151,8 @@ fi # Get ngIRCd version information eval $(grep "^VERSION = " Makefile | sed -e 's/ //g') case "$VERSION" in - *-*-*) - VERSION=`echo "$VERSION" | cut -d'-' -f3 | cut -b2-` + *~*-*) + VERSION=`echo "$VERSION" | cut -b1-10` ;; esac [ -n "$VERSION" ] || VERSION="unknown"

1 0

Alexander Barton : platformtest.sh: New option "-x", don' t renegerate build system
by alex＠arthur.barton.de 11 Jan '14

11 Jan '14

Module: ngircd.git Branch: master Commit: 97b4fd8a086af9d4a979e8fa3a714352fcffdca3 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=97b4fd8a… Author: Alexander Barton <alex(a)barton.de> Date: Sat Jan 11 01:27:12 2014 +0100 platformtest.sh: New option "-x", don't renegerate build system --- contrib/platformtest.sh | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/contrib/platformtest.sh b/contrib/platformtest.sh index 76f4169..dfefc1a 100755 --- a/contrib/platformtest.sh +++ b/contrib/platformtest.sh @@ -16,6 +16,7 @@ NAME=`basename "$0"` VERBOSE= +CLEAN=1 PLATFORM= COMPILER="unknown" @@ -36,8 +37,15 @@ while [ $# -gt 0 ]; do "-v") VERBOSE=1 ;; + "-x") + CLEAN= + ;; *) - echo "Usage: $NAME [-v]" + echo "Usage: $NAME [-v] [-x]" + echo + echo " -v Verbose output" + echo " -x Don't regenerate build system, even when possible" + echo exit 2 esac shift @@ -58,7 +66,7 @@ echo "$NAME: Checking for GIT tree ..." if [ -d .git ]; then echo "$NAME: Checking for \"git\" command ..." git version >/dev/null 2>&1 - if [ $? -eq 0 ]; then + if [ $? -eq 0 -a -n "$CLEAN" ]; then echo "$NAME: Running \"git clean\" ..." [ -n "$VERBOSE" ] && git clean -dxf || git clean -dxf >/dev/null fi

1 0

Alexander Barton : Client_SetHostname(): Don't use strlen() to test for value
by alex＠arthur.barton.de 10 Jan '14

10 Jan '14

Module: ngircd.git Branch: master Commit: fe73835666238247809d6390661f66df10362a6e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=fe738356… Author: Alexander Barton <alex(a)barton.de> Date: Fri Jan 10 19:57:03 2014 +0100 Client_SetHostname(): Don't use strlen() to test for value --- src/ngircd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/client.c b/src/ngircd/client.c index 5f01648..bfb52e8 100644 --- a/src/ngircd/client.c +++ b/src/ngircd/client.c @@ -345,7 +345,7 @@ Client_SetHostname( CLIENT *Client, const char *Hostname ) assert(Client != NULL); assert(Hostname != NULL); - if (strlen(Conf_CloakHost)) { + if (Conf_CloakHost[0]) { char cloak[GETID_LEN]; strlcpy(cloak, Hostname, GETID_LEN);

1 0

Alexander Barton : Test suite: explicitely enable glibc memory checking
by alex＠arthur.barton.de 10 Jan '14

10 Jan '14

Module: ngircd.git Branch: master Commit: 5b4b7e2f55cee950f86966df3e0f335884cf8598 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=5b4b7e2f… Author: Alexander Barton <alex(a)barton.de> Date: Fri Jan 10 19:56:08 2014 +0100 Test suite: explicitely enable glibc memory checking --- src/testsuite/start-server.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/testsuite/start-server.sh b/src/testsuite/start-server.sh index 0fd61ea..3d19ffb 100755 --- a/src/testsuite/start-server.sh +++ b/src/testsuite/start-server.sh @@ -35,6 +35,10 @@ fi # generate MOTD for test-server echo "This is an ngIRCd Test Server" > ngircd-test${id}.motd +# glibc memory checking, see malloc(3) +MALLOC_CHECK_=3 +export MALLOC_CHECK_ + # starting up test-server ... ./T-ngircd${id} -n -f ${srcdir}/ngircd-test${id}.conf $* \ >ngircd-test${id}.log 2>&1 &

1 0

Alexander Barton : Send "fake '*' key" in "MODE -k" replies
by alex＠arthur.barton.de 08 Jan '14

08 Jan '14

Module: ngircd.git Branch: master Commit: 8ae2cdfce9f8ba75fe72d65603d4c05c87f6d9c2 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=8ae2cdfc… Author: Alexander Barton <alex(a)barton.de> Date: Wed Jan 8 14:18:09 2014 +0100 Send "fake '*' key" in "MODE -k" replies According to RFC 2812 3.2.3 "Channel mode message" and the examples there, it looks like clients should use "MODE -k <key>" to unset channel keys; and that's how other servers and services behave and do expect it. (But please note that this is NOT the case for "MODE -l"!) In the end, it doesn't make sense to specify a key when UNsetting it at all, and different services behave diffrently when clients do not send the currently set key to unset it - some ignore such calls, for example! But this implementation is quite relaxed, it accepts any key when unsetting channel mode "k" and even accepts no key at all. But the reply will always include an "*" character for every "-k" parameter. --- src/ngircd/irc-mode.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c index a29ed23..a59f085 100644 --- a/src/ngircd/irc-mode.c +++ b/src/ngircd/irc-mode.c @@ -582,9 +582,13 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel) goto chan_exit; if (!set) { if (is_oper || is_machine || is_owner || - is_admin || is_op || is_halfop) + is_admin || is_op || is_halfop) { x[0] = *mode_ptr; - else + if (Channel_HasMode(Channel, 'k')) + strlcpy(argadd, "*", sizeof(argadd)); + if (arg_arg > mode_arg) + arg_arg++; + } else connected = IRC_WriteErrClient(Origin, ERR_CHANOPRIVSNEEDED_MSG, Client_ID(Origin),

1 0

Alexander Barton : Add "config.cache" to .gitignore file
by alex＠arthur.barton.de 06 Jan '14

06 Jan '14

Module: ngircd.git Branch: master Commit: 6685ae063f4e7dd75346cf50cff84c8c109e2d6b URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=6685ae06… Author: Alexander Barton <alex(a)barton.de> Date: Mon Jan 6 17:20:54 2014 +0100 Add "config.cache" to .gitignore file --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index b4d402e..ffd498c 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ ar-lib autom4te.cache build-stamp-ngircd* compile +config.cache config.log config.status configure

1 0