Oktober 2013 - ngIRCd GIT Updates

Alexander Barton : platformtest.sh: Clean up GIT source tree, when possible
by alex＠arthur.barton.de 14 Okt '13

14 Okt '13

Module: ngircd.git Branch: master Commit: 45d3e6aa91295bee056df8be5c3ed224420fba02 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=45d3e6aa… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 14 23:47:07 2013 +0200 platformtest.sh: Clean up GIT source tree, when possible --- contrib/platformtest.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/contrib/platformtest.sh b/contrib/platformtest.sh index 765fb39..ac54575 100755 --- a/contrib/platformtest.sh +++ b/contrib/platformtest.sh @@ -54,6 +54,16 @@ if [ $? -ne 0 ]; then cd .. fi +echo "$NAME: Checking for GIT tree ..." +if [ -d .git ]; then + echo "$NAME: Checking for \"git\" command ..." + git version >/dev/null 2>&1 + if [ $? -eq 0 ]; then + echo "$NAME: Running \"git clean\" ..." + [ -n "$VERBOSE" ] && git clean -dxf || git clean -dxf >/dev/null + fi +fi + echo "$NAME: Checking for \"./configure\" script ..." if [ ! -e ./configure ]; then echo "$NAME: Running \"./autogen.sh\" ..."

1 0

Alexander Barton : Update (date of) manual pages
by alex＠arthur.barton.de 07 Okt '13

07 Okt '13

Module: ngircd.git Branch: master Commit: c34b91d8ddd23c0f04da949b4f3b592ed081c729 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=c34b91d8… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 7 23:02:27 2013 +0200 Update (date of) manual pages --- man/ngircd.8.tmpl | 2 +- man/ngircd.conf.5.tmpl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/man/ngircd.8.tmpl b/man/ngircd.8.tmpl index d56dc87..524fe3c 100644 --- a/man/ngircd.8.tmpl +++ b/man/ngircd.8.tmpl @@ -1,7 +1,7 @@ .\" .\" ngircd(8) manual page template .\" -.TH ngircd 8 "Jul 2013" ngIRCd "ngIRCd Manual" +.TH ngircd 8 "Oct 2013" ngIRCd "ngIRCd Manual" .SH NAME ngIRCd \- the "next generation" IRC daemon .SH SYNOPSIS diff --git a/man/ngircd.conf.5.tmpl b/man/ngircd.conf.5.tmpl index b69649e..5ca6ee3 100644 --- a/man/ngircd.conf.5.tmpl +++ b/man/ngircd.conf.5.tmpl @@ -1,7 +1,7 @@ .\" .\" ngircd.conf(5) manual page template .\" -.TH ngircd.conf 5 "May 2013" ngIRCd "ngIRCd Manual" +.TH ngircd.conf 5 "Oct 2013" ngIRCd "ngIRCd Manual" .SH NAME ngircd.conf \- configuration file of ngIRCd .SH SYNOPSIS @@ -133,8 +133,8 @@ if ngIRCd is using PAM! .TP \fBPidFile\fR (string) This tells ngIRCd to write its current process ID to a file. Note that the -pidfile is written AFTER chroot and switching the user ID, e.g. the directory -the pidfile resides in must be writable by the ngIRCd user and exist in the +"PID file" is written AFTER chroot and switching the user ID, e.g. the directory +the file resides in must be writable by the ngIRCd user and exist in the chroot directory (if configured, see above). .TP \fBPorts\fR (list of numbers)

1 0

Alexander Barton : ChnageLog file: even more spelling fixes ...
by alex＠arthur.barton.de 07 Okt '13

07 Okt '13

Module: ngircd.git Branch: master Commit: 56da86b4f4f162851f802d9e90b2779d804f411b URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=56da86b4… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 7 22:17:49 2013 +0200 ChnageLog file: even more spelling fixes ... --- ChangeLog | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7433ff0..ce17367 100644 --- a/ChangeLog +++ b/ChangeLog @@ -18,10 +18,10 @@ ngIRCd 21~rc1 (2013-10-05) unnecessary duplicates. - Add support to show all user links using the "STATS L" (uppercase) command (restricted to IRC Operators). - - Fixed blocking of server reconnects in some error confitions. + - Fixed blocking of server reconnects in some error configurations. - Don't ignore SSL-related errors during startup any more: abort startup when SSL is requested by the configuration but can't be initialized and - don't continue only listening on plain text communicaiton ports. + don't continue only listening on plain text communication ports. (Closes bug #163) - Implement configurable SSL cipher list selection for GnuTLS and OpenSSL using the new configuration option "CipherList". In addition, this @@ -31,8 +31,8 @@ ngIRCd 21~rc1 (2013-10-05) is "syntax error") when there are too many parameters. - Clean up lots of permission and parameter checks in functions handling IRC commands; and more consistently add penalty times on errors. - - Fix error numeric of WHOIS when no nick namename has been provided: - as per RFC it shoud be ERR_NONICKNAMEGIVEN(431). + - Fix error numeric of WHOIS when no nick name has been provided: + as per RFC it should be ERR_NONICKNAMEGIVEN(431). - Only log "IDENT ... no result" messages when an IDENT looked took place and didn't return any data, not when IDENT has been disabled. - Show connection flag "s" (SSL) in RPL_TRACE{LINK|SERVER} messages: now @@ -87,7 +87,7 @@ ngIRCd 21~rc1 (2013-10-05) - OS X PackageMaker: use relative path names in project files and package with correct file permissions (requires root privileges on "make"). - Add Travis-CI configuration file (".travis.yml") to project. - - Look for possible cloaked Masks in Lists. Users with +x usermode can + - Look for possible cloaked Masks in Lists. Users with +x user mode can be banned with their cloaked hostname now. - Don't read SSL client data before DNS resolver is finished which could have resulted in discarding the resolved client hostname and IDENT

1 0

Alexander Barton : INSTALL file: Update "Upgrade Information"
by alex＠arthur.barton.de 07 Okt '13

07 Okt '13

Module: ngircd.git Branch: master Commit: ea8a2bf1fc786874010c8a6ef84b3142c536112e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=ea8a2bf1… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 7 22:15:22 2013 +0200 INSTALL file: Update "Upgrade Information" --- INSTALL | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index eec2b37..bbff1f2 100644 --- a/INSTALL +++ b/INSTALL @@ -12,13 +12,17 @@ I. Upgrade Information ~~~~~~~~~~~~~~~~~~~~~~ -Differences to previous version +Differences to version 20.x - Starting with ngIRCd 21, the ciphers used by SSL are configurable and default to HIGH:!aNULL:@STRENGTH (OpenSSL) or SECURE128 (GnuTLS). Previous version were using the OpenSSL or GnuTLS defaults, DEFAULT and NORMAL respectively. +- When adding GLINE's or KLINE's to ngIRCd 21 (or newer), all clients matching + the new mask will be KILL'ed. This was not the case with earlier versions + that only added the mask but didn't kill already connected users. + Differences to version 19.x - Starting with ngIRCd 20, users can "cloak" their hostname only when the

1 0

Alexander Barton : Fix spelling in NEWS and ChangeLog files
by alex＠arthur.barton.de 07 Okt '13

07 Okt '13

Module: ngircd.git Branch: master Commit: 1b349b05d5040de19921f087785310dfe24ef5df URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=1b349b05… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 7 21:59:02 2013 +0200 Fix spelling in NEWS and ChangeLog files --- ChangeLog | 4 ++-- NEWS | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index cbf5d2c..7433ff0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -59,7 +59,7 @@ ngIRCd 21~rc1 (2013-10-05) If set to the empty string, local clients can't create new channels at all, which equals the old "PredefChannelsOnly = yes" setting. This change deprecates the "PredefChannelsOnly" variable, too, but it is - still supported and translated to the apropriate "AllowedChannelTypes" + still supported and translated to the appropriate "AllowedChannelTypes" setting. When the old "PredefChannelsOnly" variable is processed, a warning message is logged. (Closes bug #152) - Add support for "client certificate fingerprinting". When a client @@ -125,7 +125,7 @@ ngIRCd 21~rc1 (2013-10-05) InspIRCd, for example -- but as usual, other numerics are in use, too, like 613 in UltimateIRCd ... Please note that neither the Operator (+o) not the "bot status" (+B) - of an IRC service id displayed in the output. + of an IRC service is displayed in the output. - Exit message: use singular & plural :-) - autogen.sh: Check for autoconf/automake wrapper scripts - Add missing punctuation marks in log messages, adjust some severity diff --git a/NEWS b/NEWS index e8f898a..785ce03 100644 --- a/NEWS +++ b/NEWS @@ -36,7 +36,7 @@ ngIRCd 21~rc1 (2013-10-05) If set to the empty string, local clients can't create new channels at all, which equals the old "PredefChannelsOnly = yes" setting. This change deprecates the "PredefChannelsOnly" variable, too, but it is - still supported and translated to the apropriate "AllowedChannelTypes" + still supported and translated to the appropriate "AllowedChannelTypes" setting. When the old "PredefChannelsOnly" variable is processed, a warning message is logged. (Closes bug #152) - Add support for "client certificate fingerprinting". When a client @@ -72,7 +72,7 @@ ngIRCd 21~rc1 (2013-10-05) InspIRCd, for example -- but as usual, other numerics are in use, too, like 613 in UltimateIRCd ... Please note that neither the Operator (+o) not the "bot status" (+B) - of an IRC service id displayed in the output. + of an IRC service is displayed in the output. - Update systemd(8) example configuration files in ./contrib/ directory: the "ngircd.service" file now uses the "forking" service type which enhances the log messages shown by "systemctl status ngircd.service",

1 0

Alexander Barton : ngircd.c, main(): use strlcat() instead of strcat()
by alex＠arthur.barton.de 07 Okt '13

07 Okt '13

Module: ngircd.git Branch: master Commit: 4c5b439992ce99f1bed84c51e4d9c3a3cd118858 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=4c5b4399… Author: Alexander Barton <alex(a)barton.de> Date: Mon Oct 7 21:56:09 2013 +0200 ngircd.c, main(): use strlcat() instead of strcat() This fixes the following warning on OpenBSD 5.3: ngircd.o(.text+0xeb4): In function `main': src/ngircd/ngircd.c:300: warning: strcat() is almost always misused, please use strlcat() Thanks to Götz Hoffart for reporting this! --- src/ngircd/ngircd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c index 5637cb2..9c27409 100644 --- a/src/ngircd/ngircd.c +++ b/src/ngircd/ngircd.c @@ -297,7 +297,7 @@ main(int argc, const char *argv[]) PROTOVER, PROTOIRCPLUS, PACKAGE_NAME, PACKAGE_VERSION, IRCPLUSFLAGS); #ifdef ZLIB - strcat(NGIRCd_ProtoID, "Z"); + strlcat(NGIRCd_ProtoID, "Z", sizeof NGIRCd_ProtoID); #endif if (Conf_OperCanMode) strcat(NGIRCd_ProtoID, "o");

1 0

Tag rel-21-rc1: Alexander Barton : ngIRCd Release 21~rc1
by alex＠arthur.barton.de 05 Okt '13

05 Okt '13

Module: ngircd.git Branch: refs/tags/rel-21-rc1 Tag: e1de5e4ec63ae2b674775c78482cafdd1be00c4c URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=tag;h=e1de5e4ec63… Tagger: Alexander Barton <alex(a)barton.de> Date: Sat Oct 5 23:40:43 2013 +0200 ngIRCd Release 21~rc1

1 0

Alexander Barton : ngIRCd Release 21~rc1
by alex＠arthur.barton.de 05 Okt '13

05 Okt '13

Module: ngircd.git Branch: master Commit: 86cd2da8d5dc08eedbf23be5249d1cc3a16f0787 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=86cd2da8… Author: Alexander Barton <alex(a)barton.de> Date: Sat Oct 5 23:40:29 2013 +0200 ngIRCd Release 21~rc1 --- ChangeLog | 2 +- NEWS | 2 +- contrib/Debian/changelog | 6 ++++++ contrib/ngircd.spec | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 22e558d..cbf5d2c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,7 +9,7 @@ -- ChangeLog -- -ngIRCd 21 +ngIRCd 21~rc1 (2013-10-05) - Actually KILL clients on GLINE/KLINE. (Closes bug #156) - Adjust log messages for invalid and spoofed prefixes, which cleans up diff --git a/NEWS b/NEWS index 6b40328..e8f898a 100644 --- a/NEWS +++ b/NEWS @@ -9,7 +9,7 @@ -- NEWS -- -ngIRCd 21 +ngIRCd 21~rc1 (2013-10-05) - Actually KILL clients on GLINE/KLINE. (Closes bug #156) - Add support to show all user links using the "STATS L" (uppercase) diff --git a/contrib/Debian/changelog b/contrib/Debian/changelog index 396d1d0..46646fc 100644 --- a/contrib/Debian/changelog +++ b/contrib/Debian/changelog @@ -1,3 +1,9 @@ +ngircd (21~rc1-0ab1) unstable; urgency=low + + * New "upstream" release candidate 1 for ngIRCd Release 21. + + -- Alexander Barton <alex(a)barton.de> Sat, 05 Oct 2013 23:24:09 +0200 + ngircd (20.3-0ab1) unstable; urgency=high * New "upstream" release, fixing a security related bug: ngIRCd 20.3. diff --git a/contrib/ngircd.spec b/contrib/ngircd.spec index 0469313..65df307 100644 --- a/contrib/ngircd.spec +++ b/contrib/ngircd.spec @@ -1,5 +1,5 @@ %define name ngircd -%define version 20.3 +%define version 21~rc1 %define release 1 %define prefix %{_prefix}

1 0

Alexander Barton : Update NEWS and ChangeLog files
by alex＠arthur.barton.de 02 Okt '13

02 Okt '13

Module: ngircd.git Branch: master Commit: 9b1fee8995f5e1ee5390ba36635804744a368c94 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=9b1fee89… Author: Alexander Barton <alex(a)barton.de> Date: Wed Oct 2 02:10:48 2013 +0200 Update NEWS and ChangeLog files --- ChangeLog | 42 +++++++++++++++++++++++++++++++++++++++++- NEWS | 19 +++++++++++++++++++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 1186276..22e558d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,45 @@ ngIRCd 21 + - Actually KILL clients on GLINE/KLINE. (Closes bug #156) + - Adjust log messages for invalid and spoofed prefixes, which cleans up + logging of commands related to already KILL'ed clients. And don't + forward KILL commands for (already) unknown clients any more to prevent + unnecessary duplicates. + - Add support to show all user links using the "STATS L" (uppercase) + command (restricted to IRC Operators). + - Fixed blocking of server reconnects in some error confitions. + - Don't ignore SSL-related errors during startup any more: abort startup + when SSL is requested by the configuration but can't be initialized and + don't continue only listening on plain text communicaiton ports. + (Closes bug #163) + - Implement configurable SSL cipher list selection for GnuTLS and OpenSSL + using the new configuration option "CipherList". In addition, this + changes the defaults to more secure values: "HIGH:!aNULL:@STRENGTH" for + OpenSSL, and "SECURE128" for GnuTLS. + - Fix "TRACE": Correctly return ERR_NEEDMOREPARAMS(461) (which basically + is "syntax error") when there are too many parameters. + - Clean up lots of permission and parameter checks in functions handling + IRC commands; and more consistently add penalty times on errors. + - Fix error numeric of WHOIS when no nick namename has been provided: + as per RFC it shoud be ERR_NONICKNAMEGIVEN(431). + - Only log "IDENT ... no result" messages when an IDENT looked took place + and didn't return any data, not when IDENT has been disabled. + - Show connection flag "s" (SSL) in RPL_TRACE{LINK|SERVER} messages: now + you can check if a server-to-server link is SSL-encrypted or not using + the IRC "TRACE" command. + - Correctly discard supplementary groups on server startup. + - Save client IP address text for "WebIRC" users and correctly display + it on WHOIS, for example. (Closes bug #159) + - Implement the new configuration option "DefaultUserModes" which lists + user modes that become automatically set on new local clients right + after login. Please note that only modes can be set that the client + could set on itself, so you can't set "a" (away) or "o" (IRC Op), + for example! User modes "i" (invisible) or "x" (cloaked) etc. are + "interesting", though. (Closes bug #160) + - Add support for the new METADATA "account" property, which allows + services to automatically identify users after netsplits and across + service restarts. - Enforce "penalty times" on error conditions more consistently and in more places. Now most error codes sent back from the IRC server to the client should result in a 2 second "penalty". @@ -43,7 +82,8 @@ ngIRCd 21 into this directory. (Closes bug #157) - Fix use-after-free in the Lists_CheckReason() function, which is used to check if a client is a member of a particular ban/invite/... list. - - Xcode: fix detection of host OS, vendor, and CPU type. + - Xcode: fix detection of host OS, vendor, and CPU type, and update + project settings for Xcode 5. - OS X PackageMaker: use relative path names in project files and package with correct file permissions (requires root privileges on "make"). - Add Travis-CI configuration file (".travis.yml") to project. diff --git a/NEWS b/NEWS index a8dc433..6b40328 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,25 @@ ngIRCd 21 + - Actually KILL clients on GLINE/KLINE. (Closes bug #156) + - Add support to show all user links using the "STATS L" (uppercase) + command (restricted to IRC Operators). + - Implement configurable SSL cipher list selection for GnuTLS and OpenSSL + using the new configuration option "CipherList". In addition, this + changes the defaults to more secure values: "HIGH:!aNULL:@STRENGTH" for + OpenSSL, and "SECURE128" for GnuTLS. + - Show connection flag "s" (SSL) in RPL_TRACE{LINK|SERVER} messages: now + you can check if a server-to-server link is SSL-encrypted or not using + the IRC "TRACE" command. + - Implement the new configuration option "DefaultUserModes" which lists + user modes that become automatically set on new local clients right + after login. Please note that only modes can be set that the client + could set on itself, so you can't set "a" (away) or "o" (IRC Op), + for example! User modes "i" (invisible) or "x" (cloaked) etc. are + "interesting", though. (Closes bug #160) + - Add support for the new METADATA "account" property, which allows + services to automatically identify users after netsplits and across + service restarts. - Implement a new configuration option "AllowedChannelTypes" that lists all allowed channel types (channel prefixes) for newly created channels on the local server. By default, all supported channel types are allowed.

1 0

Alexander Barton : Actually KILL clients on GLINE/KLINE
by alex＠arthur.barton.de 01 Okt '13

01 Okt '13

Module: ngircd.git Branch: master Commit: 2798a12444bce91613388ceb7ab52d1e97787687 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=2798a124… Author: Alexander Barton <alex(a)barton.de> Date: Tue Oct 1 12:09:59 2013 +0200 Actually KILL clients on GLINE/KLINE Kill all clients that match a new GLINE/KLINE mask and genrate apropriate KILL commands. These KILL commands can be superfluous, but are required when the IRC Operator isn't allowd to set remote G-Lines or if there are older servers in the network that don't kill clients on GLINE/KLINE. Closes bug #156. --- src/ngircd/irc-oper.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/ngircd/irc-oper.c b/src/ngircd/irc-oper.c index 74f17cc..4ccc76a 100644 --- a/src/ngircd/irc-oper.c +++ b/src/ngircd/irc-oper.c @@ -28,12 +28,14 @@ #include "conf.h" #include "channel.h" #include "class.h" +#include "parse.h" +#include "irc.h" #include "irc-macros.h" #include "irc-write.h" +#include "lists.h" #include "log.h" #include "match.h" #include "messages.h" -#include "parse.h" #include "op.h" #include <exp.h> @@ -384,9 +386,10 @@ IRC_WALLOPS( CLIENT *Client, REQUEST *Req ) GLOBAL bool IRC_xLINE(CLIENT *Client, REQUEST *Req) { - CLIENT *from; + CLIENT *from, *c, *c_next; + char reason[COMMAND_LEN], class_c; + struct list_head *list; int class; - char class_c; assert(Client != NULL); assert(Req != NULL); @@ -446,6 +449,20 @@ IRC_xLINE(CLIENT *Client, REQUEST *Req) Req->argv[0], Req->argv[1], Req->argv[2]); } + + /* Check currently connected clients */ + snprintf(reason, sizeof(reason), "%c-Line by \"%s\": \"%s\"", + class_c, Client_ID(from), Req->argv[2]); + list = Class_GetList(class); + c = Client_First(); + while (c) { + c_next = Client_Next(c); + if ((class == CLASS_GLINE || Client_Conn(c) > NONE) + && Lists_Check(list, c)) + IRC_KillClient(Client, NULL, + Client_ID(c), reason); + c = c_next; + } } }

1 0