ngIRCd GIT Updates

Diskussionsstrang Neuen Diskussionsstrang anfangen

Herunterladen

ngircd-commits@lists.barton.de

April 2012

1 Teilnehmer
22 Diskussionen

Alexander Barton : Lists_Add(): use size of destination when copying data
by alex＠arthur.barton.de 17 Apr '12

17 Apr '12

Module: ngircd.git Branch: master Commit: 8ec17063a6e651229e04605592ce3d6114075655 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=8ec17063… Author: Alexander Barton <alex(a)barton.de> Date: Tue Apr 17 12:54:38 2012 +0200 Lists_Add(): use size of destination when copying data This fixes the following warning of clang: /src/ngircd/lists.c:152:44: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] But it isn't a real problem, because the size of the source always is the same than the size of the destination ... --- src/ngircd/lists.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ngircd/lists.c b/src/ngircd/lists.c index 4f57ca7..45a4874 100644 --- a/src/ngircd/lists.c +++ b/src/ngircd/lists.c @@ -149,7 +149,8 @@ Lists_Add(struct list_head *h, const char *Mask, time_t ValidUntil, if (Reason) { newelem->reason = malloc(strlen(Reason) + 1); if (newelem->reason) - strlcpy(newelem->reason, Reason, strlen(Reason) + 1); + strlcpy(newelem->reason, Reason, + sizeof(newelem->reason)); else Log(LOG_EMERG, "Can't allocate memory for new list reason text!");

1 0

Alexander Barton : Xcode: correctly sort conn-ssl.{c|h} files in file list
by alex＠arthur.barton.de 17 Apr '12

17 Apr '12

Module: ngircd.git Branch: master Commit: 69be7a85a2117f0526ca4e113a806be989dc2f53 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=69be7a85… Author: Alexander Barton <alex(a)barton.de> Date: Tue Apr 17 12:57:27 2012 +0200 Xcode: correctly sort conn-ssl.{c|h} files in file list --- contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj index b6e51c7..289c2ed 100644 --- a/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj +++ b/contrib/MacOSX/ngIRCd.xcodeproj/project.pbxproj @@ -305,8 +305,6 @@ isa = PBXGroup; children = ( FA322D020CEF74B1001761B3 /* Makefile.am */, - FAA3D2790F139CDC00B2447E /* conn-ssl.c */, - FAA3D27A0F139CDC00B2447E /* conn-ssl.h */, FA322CD90CEF74B1001761B3 /* array.c */, FA322CDA0CEF74B1001761B3 /* array.h */, FA322CDB0CEF74B1001761B3 /* channel.c */, @@ -324,6 +322,8 @@ FA322CE40CEF74B1001761B3 /* conn-zip.h */, FA322CE50CEF74B1001761B3 /* conn.c */, FA322CE60CEF74B1001761B3 /* conn.h */, + FAA3D2790F139CDC00B2447E /* conn-ssl.c */, + FAA3D27A0F139CDC00B2447E /* conn-ssl.h */, FA322CE70CEF74B1001761B3 /* defines.h */, FA322CE80CEF74B1001761B3 /* hash.c */, FA322CE90CEF74B1001761B3 /* hash.h */,

1 0