- ngIRCd GIT Updates - lists.barton.de

Alexander Barton : Auth PING: Fix our information text for manual sending of "PONG"
by alex＠arthur.barton.de 20 Jan '15

20 Jan '15

Module: ngircd.git Branch: master Commit: c41f18e3f90512afcf38f42695c26708a1f34772 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=c41f18e3… Author: Alexander Barton <alex(a)barton.de> Date: Tue Jan 20 22:50:13 2015 +0100 Auth PING: Fix our information text for manual sending of "PONG" Up to now, ngIRCd doesn't send a valid IRC command at all, oops! --- src/ngircd/irc-login.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c index fbb50ed..98ac0e7 100644 --- a/src/ngircd/irc-login.c +++ b/src/ngircd/irc-login.c @@ -838,8 +838,8 @@ IRC_PONG(CLIENT *Client, REQUEST *Req) Login_User(Client); } else if (!IRC_WriteStrClient(Client, - "To connect, type /QUOTE PONG %ld", - auth_ping)) + "NOTICE %s :To connect, type /QUOTE PONG %ld", + Client_ID(Client), auth_ping)) return DISCONNECTED; } #endif

1 0

Alexander Barton : Auth PING: The numeric ID is a "long", use atol()
by alex＠arthur.barton.de 20 Jan '15

20 Jan '15

Module: ngircd.git Branch: master Commit: dbfe1beca83a80c7fc9e25470a75bca78f64d634 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=dbfe1bec… Author: Alexander Barton <alex(a)barton.de> Date: Tue Jan 20 22:49:23 2015 +0100 Auth PING: The numeric ID is a "long", use atol() --- src/ngircd/irc-login.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c index 7ad1cb7..fbb50ed 100644 --- a/src/ngircd/irc-login.c +++ b/src/ngircd/irc-login.c @@ -832,7 +832,7 @@ IRC_PONG(CLIENT *Client, REQUEST *Req) if (auth_ping) { LogDebug("AUTH PONG: waiting for token \"%ld\", got \"%s\" ...", auth_ping, Req->argv[0]); - if (auth_ping == atoi(Req->argv[0])) { + if (auth_ping == atol(Req->argv[0])) { Conn_SetAuthPing(conn, 0); if (Client_Type(Client) == CLIENT_WAITAUTHPING) Login_User(Client);

1 0

Alexander Barton : Auth PING: Don't send a prefix in our PING command
by alex＠arthur.barton.de 20 Jan '15

20 Jan '15

Module: ngircd.git Branch: master Commit: 6bdae55177bf3d8910a77bc0af14c0de3d4fd4c9 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=6bdae551… Author: Alexander Barton <alex(a)barton.de> Date: Tue Jan 20 22:44:36 2015 +0100 Auth PING: Don't send a prefix in our PING command The prefix confuses WeeChat, at least, which doesn't send an appropriate PONG in the case ... Debugging and patch by "wowaname" on #ngircd, thanks! --- src/ngircd/irc-login.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c index af165cf..7ad1cb7 100644 --- a/src/ngircd/irc-login.c +++ b/src/ngircd/irc-login.c @@ -243,7 +243,7 @@ IRC_NICK( CLIENT *Client, REQUEST *Req ) #else Conn_SetAuthPing(Client_Conn(Client), rand()); #endif - IRC_WriteStrClient(Client, "PING :%ld", + Conn_WriteStr(Client_Conn(Client), "PING :%ld", Conn_GetAuthPing(Client_Conn(Client))); LogDebug("Connection %d: sent AUTH PING %ld ...", Client_Conn(Client),

1 0

Alexander Barton : FAQ: How can I "auto-op" users in channels?
by alex＠arthur.barton.de 13 Jan '15

13 Jan '15

Module: ngircd.git Branch: master Commit: fb5ae9e844ee30208f81204cd977469543fd1cc0 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=fb5ae9e8… Author: Alexander Barton <alex(a)barton.de> Date: Tue Jan 13 12:44:29 2015 +0100 FAQ: How can I "auto-op" users in channels? --- doc/FAQ.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/FAQ.txt b/doc/FAQ.txt index fe8510b..79ca2d7 100644 --- a/doc/FAQ.txt +++ b/doc/FAQ.txt @@ -89,6 +89,11 @@ A: You need to set 'OperCanUseMode = yes' in ngircd.conf, then IRC operators can use the MODE command for changing modes even when they are not joined to the specific channel. +Q: How can I "auto-op" users in channels? +A: ngIRCd can't do this: you would have to use some "IRC Services", like + Atheme (<http://atheme.net/atheme.html>) or Anope (<http://www.anope.org>). + See "doc/Services.txt" for setup instructions. + IV. Bugs!? ~~~~~~~~~~

1 0

Alexander Barton : Fix syntax of ERR_LISTFULL_MSG(478) numeric
by alex＠arthur.barton.de 27 Dez '14

27 Dez '14

Module: ngircd.git Branch: master Commit: bd8d4e710c0cb597ef10f23691602256d44895ea URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=bd8d4e71… Author: Alexander Barton <alex(a)barton.de> Date: Sat Dec 27 01:39:07 2014 +0100 Fix syntax of ERR_LISTFULL_MSG(478) numeric Pointed out by "wowaname" in #ngircd, thanks! --- src/ngircd/messages.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ngircd/messages.h b/src/ngircd/messages.h index a56bf86..0115a06 100644 --- a/src/ngircd/messages.h +++ b/src/ngircd/messages.h @@ -1,6 +1,6 @@ /* * ngIRCd -- The Next Generation IRC Daemon - * Copyright (c)2001-2013 Alexander Barton (alex(a)barton.de) and Contributors. + * Copyright (c)2001-2014 Alexander Barton (alex(a)barton.de) and Contributors. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -141,7 +141,7 @@ #define ERR_BADCHANNELKEY_MSG "475 %s %s :Cannot join channel (+k) -- Wrong channel key" #define ERR_NOCHANMODES_MSG "477 %s %s :Channel doesn't support modes" #define ERR_NEEDREGGEDNICK_MSG "477 %s %s :Cannot send to channel (+M) -- You need to be identified to a registered account to message this channel" -#define ERR_LISTFULL_MSG "478 %s %s %s: Channel list is full (%d)" +#define ERR_LISTFULL_MSG "478 %s %s %s :Channel list is full (%d)" #define ERR_NOPRIVILEGES_MSG "481 %s :Permission denied" #define ERR_CHANOPRIVSNEEDED_MSG "482 %s %s :You are not channel operator" #define ERR_CHANOPPRIVTOOLOW_MSG "482 %s %s :Your privileges are too low"

1 0

Alexander Barton : Enhance debug messages while sending CHANINFO commands
by alex＠arthur.barton.de 20 Dez '14

20 Dez '14

Module: ngircd.git Branch: master Commit: 9a931a549b7e1b0979ce5f6088edf5136546f3ed URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=9a931a54… Author: Alexander Barton <alex(a)barton.de> Date: Sat Dec 20 15:35:47 2014 +0100 Enhance debug messages while sending CHANINFO commands --- src/ngircd/numeric.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ngircd/numeric.c b/src/ngircd/numeric.c index b0ceeef..7d32ddc 100644 --- a/src/ngircd/numeric.c +++ b/src/ngircd/numeric.c @@ -216,7 +216,8 @@ Send_CHANINFO(CLIENT * Client, CHANNEL * Chan) bool has_k, has_l; #ifdef DEBUG - Log(LOG_DEBUG, "Sending CHANINFO commands ..."); + Log(LOG_DEBUG, "Sending CHANINFO commands for \"%s\" ...", + Channel_Name(Chan)); #endif modes = Channel_Modes(Chan);

1 0

Alexander Barton : Reset "last try" timer when enabling a passive server
by alex＠arthur.barton.de 20 Dez '14

20 Dez '14

Module: ngircd.git Branch: master Commit: 3c30490d54da941e368d54aeb63cf56cf1aef345 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=3c30490d… Author: Alexander Barton <alex(a)barton.de> Date: Sat Dec 20 15:31:30 2014 +0100 Reset "last try" timer when enabling a passive server This results in a new connection attempt as soon as possible. --- src/ngircd/conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ngircd/conf.c b/src/ngircd/conf.c index 5f8c392..221e7a9 100644 --- a/src/ngircd/conf.c +++ b/src/ngircd/conf.c @@ -618,6 +618,7 @@ Conf_EnablePassiveServer(const char *Name) && (Conf_Server[i].port > 0)) { /* BINGO! Enable server */ Conf_Server[i].flags &= ~CONF_SFLAG_DISABLED; + Conf_Server[i].lasttry = 0; return true; } }

1 0

Alexander Barton : Change log message for "Can't resolve address"
by alex＠arthur.barton.de 10 Dez '14

10 Dez '14

Module: ngircd.git Branch: master Commit: 62503353525fd893156731521edc95b2bd6a1f6f URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=62503353… Author: Alexander Barton <alex(a)barton.de> Date: Wed Dec 10 11:11:42 2014 +0100 Change log message for "Can't resolve address" --- src/ngircd/resolve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ngircd/resolve.c b/src/ngircd/resolve.c index 0d6a294..3279190 100644 --- a/src/ngircd/resolve.c +++ b/src/ngircd/resolve.c @@ -217,8 +217,8 @@ ReverseLookup(const ng_ipaddr_t *IpAddr, char *resbuf, size_t reslen) assert(reslen >= NG_INET_ADDRSTRLEN); ng_ipaddr_tostr_r(IpAddr, tmp_ip_str); - Log_Subprocess(LOG_WARNING, "%s: Can't resolve address \"%s\": %s", - funcname, tmp_ip_str, errmsg); + Log_Subprocess(LOG_WARNING, "Can't resolve address \"%s\": %s [%s].", + tmp_ip_str, errmsg, funcname); strlcpy(resbuf, tmp_ip_str, reslen); return false; }

1 0

Alexander Barton : Change log messages issued for IP address forgeries
by alex＠arthur.barton.de 10 Dez '14

10 Dez '14

Module: ngircd.git Branch: master Commit: 7e14bd3b58522ac34f0af29182248df1577d99c9 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=7e14bd3b… Author: Alexander Barton <alex(a)barton.de> Date: Wed Dec 10 11:01:51 2014 +0100 Change log messages issued for IP address forgeries --- src/ngircd/resolve.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ngircd/resolve.c b/src/ngircd/resolve.c index be41ec8..0d6a294 100644 --- a/src/ngircd/resolve.c +++ b/src/ngircd/resolve.c @@ -334,14 +334,16 @@ static void Log_Forgery_NoIP(const char *ip, const char *host) { Log_Subprocess(LOG_WARNING, - "Possible forgery: %s resolved to %s (which has no ip address)", ip, host); + "Possible forgery: %s resolved to \"%s\", which has no IP address!", + ip, host); } static void Log_Forgery_WrongIP(const char *ip, const char *host) { Log_Subprocess(LOG_WARNING, - "Possible forgery: %s resolved to %s (which points to different address)", ip, host); + "Possible forgery: %s resolved to \"%s\", which points to a different address!", + ip, host); }

1 0

Alexander Barton : Merge remote-tracking branch 'alex/TestsuiteNoDNS'
by alex＠arthur.barton.de 01 Nov '14

01 Nov '14

Module: ngircd.git Branch: master Commit: 31b3c83c1f1b18fa1ed0501e95ed8e5f6cc6d407 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=31b3c83c… Author: Alexander Barton <alex(a)barton.de> Date: Sat Nov 1 20:14:09 2014 +0100 Merge remote-tracking branch 'alex/TestsuiteNoDNS' * alex/TestsuiteNoDNS: Test suite: Don't use DNS lookups ---

1 0