Make all channels permanent, by default?
Hi All, I'm trying to use ngircd in such a manner that all channels are: (a) persisted by default, even if created by non-privileged users, and (b) persisted between restarts of the daemon
From reading the docs I gather (b) 'just happens' with +P, but I have no idea how to achieve (a). Could someone please point me at the relevant documentation?
Thanks :) -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Hi Duncan! Am 27.02.2018 um 07:27 schrieb Duncan Bayne <duncan@bayne.id.au>:
I'm trying to use ngircd in such a manner that all channels are:
(a) persisted by default, even if created by non-privileged users, and
(b) persisted between restarts of the daemon
From reading the docs I gather (b) 'just happens' with +P, but I have no idea how to achieve (a). Could someone please point me at the relevant documentation?
Both isn't possible with current ngIRCd: Canels are only "persistent" (exist even when no users are joined to them) when they are +P, and this mode can only be set - in the configuration file(s) or - by IRC operators during runtime. If set during runtime, this information isn't saved and therefore gets lost when restarting the daemon. Alex
Alexander Barton writes:
Canels are only "persistent" (exist even when no users are joined to them) when they are +P, and this mode can only be set
- in the configuration file(s) or - by IRC operators during runtime.
If set during runtime, this information isn't saved and therefore gets lost when restarting the daemon.
Would you be interested in a pull request / patch to make that behaviour configurable, or is that sufficiently niche that I should just run my own fork? -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Hi Duncan! Am 14.03.2018 um 07:30 schrieb Duncan Bayne <duncan@bayne.id.au>:
Alexander Barton writes:
Canels are only "persistent" (exist even when no users are joined to them) when they are +P, and this mode can only be set
- in the configuration file(s) or - by IRC operators during runtime.
If set during runtime, this information isn't saved and therefore gets lost when restarting the daemon.
Would you be interested in a pull request / patch to make that behaviour configurable, or is that sufficiently niche that I should just run my own fork?
If you’d be willing to share your code/patch, that would be great! And if it isn’t to special and has no drawbacks, merging it is definitely an option. Alex
Alexander Barton writes:
Would you be interested in a pull request / patch to make that behaviour configurable, or is that sufficiently niche that I should just run my own fork?
If you’d be willing to share your code/patch, that would be great!
And if it isn’t to special and has no drawbacks, merging it is definitely an option.
Great :) Quick question, what's the dev process for ngircd like? GitHub / GitLab / mailing list + patches / ... ? -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Am 16.03.2018 um 07:20 schrieb Duncan Bayne <duncan@bayne.id.au>:
Alexander Barton writes:
Would you be interested in a pull request / patch to make that behaviour configurable, or is that sufficiently niche that I should just run my own fork?
If you’d be willing to share your code/patch, that would be great!
And if it isn’t to special and has no drawbacks, merging it is definitely an option.
Great :) Quick question, what's the dev process for ngircd like? GitHub / GitLab / mailing list + patches / ... ?
GitHub ("pull request") ist the best, but plain patches work as well. Alex
Alexander Barton writes:
GitHub ("pull request") ist the best, but plain patches work as well.
Right, I've forked it and will raise a PR as soon as three children, a surprise house-guest, and a full-time job allow :) One final question: is there a test suite of some sort? I was planning to spin up an instance and test it with a client, manually, but figure some sort of test harness to do that automagically would be nice. If there isn't, would you like me to contribute one? -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Am 17.03.2018 um 23:51 schrieb Duncan Bayne <duncan@bayne.id.au>:
One final question: is there a test suite of some sort? I was planning to spin up an instance and test it with a client, manually, but figure some sort of test harness to do that automagically would be nice.
If there isn't, would you like me to contribute one?
contrib/platformtest.sh could help? Regards Götz
Götz Hoffart writes:
If there isn't, would you like me to contribute one?
contrib/platformtest.sh could help?
That's the sort of thing; I was imagining perhaps an extension to that that would spin up ngIRCd with known configurations (i.e. with, and without, my new setting) and test that the client behaviour was as intended. -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Am 17.03.2018 um 23:51 schrieb Duncan Bayne <duncan@bayne.id.au>:
Alexander Barton writes:
GitHub ("pull request") ist the best, but plain patches work as well.
Right, I've forked it and will raise a PR as soon as three children, a surprise house-guest, and a full-time job allow :)
One final question: is there a test suite of some sort? I was planning to spin up an instance and test it with a client, manually, but figure some sort of test harness to do that automagically would be nice.
If there isn't, would you like me to contribute one?
There is a quite simple test suite that checks basic functionality: you can run it using "make check". It requires expect(1) and telnet(1) to be available. Basically contrib/platformtest.sh (which you can run, too, as Götz already suggested) does nothinging else than running "make check" and pretty print its results. Thanks! Alex
Alexander Barton writes:
There is a quite simple test suite that checks basic functionality: you can run it using "make check". It requires expect(1) and telnet(1) to be available.
Great, thanks :) Do you see my change (configurable permanent channels by default) being something tested at the integration level ('make check', as described above) or at a unit level (with something like cunit?). Or both? I'm happy to take whichever approach you'd prefer. -- Duncan Bayne +61 420 817 082 | https://duncan.bayne.id.au/ I usually check my mail every 24 - 48 hours. If there's something urgent going on, please send me an SMS or call me.
Hi Duncan, Am 20.03.2018 um 07:40 schrieb Duncan Bayne <duncan@bayne.id.au>:
Alexander Barton writes:
There is a quite simple test suite that checks basic functionality: you can run it using "make check". It requires expect(1) and telnet(1) to be available.
Great, thanks :)
Do you see my change (configurable permanent channels by default) being something tested at the integration level ('make check', as described above) or at a unit level (with something like cunit?). Or both?
I'm happy to take whichever approach you'd prefer.
The most important thing is a clean patch that makes sense :-) There are no unit tests in ngIRCd, and I don't think we should bother too much (and I'm not sure if I wanted to merge a new test system that only covers a very small part of the code base). Keeping "make check" up to date and extending it makes sens, though, I think. Thanks! Alex
participants (3)
-
Alexander Barton -
Duncan Bayne -
Götz Hoffart