On 10/24/2012 03:39 PM, Alexander Barton wrote:
Am 24.10.2012 um 17:47 schrieb Brett Smith brett@w3.org:
On 10/24/2012 11:35 AM, Alexander Barton wrote: Sorry, yes, that was my mix-up; everywhere I said CLIENT_ID_LEN, read CLIENT_USER_LEN instead. We had one user whose username was exactly ten characters, so it got truncated by the terminating null, which caused PAM authentication to fail.
Okay, I see. And I don't see why we can't augment this limit to some other sane default (when not in "strict" mode, probably). Suggestions for a higher limit? 20?
I think making this dynamic is overkill …
20 would work for me. We have only one account with a longer name, and that's a company account that's not going to be logging into IRC directly.
We have more than 100 accounts with 15-character usernames, so we would need at least 16.
- MAX_RPL_LIST: We generally have around 200 channels, so the default
limit of 100 seemed a little sharp to us.
[snip]
I happily will take a patch introducing a new "MaxListSize" (or something like this) configuration option ;-)
Great, I'll get to work on it.
And powering on my brain, I think it is already fixed in our master branch, see commit 2205227c (http://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git;a=commitdiff;h=22052...) and bug #125 (https://arthur.barton.de/bugzilla/show_bug.cgi?id=125).
That's even better. That was the patch I was most nervous about writing, so I'm glad I don't have to now. Thanks for letting me know.
Best regards,