Hi Duncan,
Am 20.03.2018 um 07:40 schrieb Duncan Bayne duncan@bayne.id.au:
Alexander Barton writes:
There is a quite simple test suite that checks basic functionality: you can run it using "make check". It requires expect(1) and telnet(1) to be available.
Great, thanks :)
Do you see my change (configurable permanent channels by default) being something tested at the integration level ('make check', as described above) or at a unit level (with something like cunit?). Or both?
I'm happy to take whichever approach you'd prefer.
The most important thing is a clean patch that makes sense :-)
There are no unit tests in ngIRCd, and I don't think we should bother too much (and I'm not sure if I wanted to merge a new test system that only covers a very small part of the code base). Keeping "make check" up to date and extending it makes sens, though, I think.
Thanks! Alex