Re: [ngIRCd-ML] [PATCH] Fix handling of localhost in Cygwin on Vista

Ali Shemiran <ashemira@ucsd.edu> wrote: [..]

Client_Hostname( CLIENT *Client ) { assert( Client != NULL ); + +#ifdef __CYGWIN__ + if (strcmp(Client->host, "127.0.0.1") == 0) + return "localhost"; +#endif + return Client->host; } /* Client_Hostname */

Ewww.... This is quite a hack... Why is it needed? Why does cygwin need special treatment vs. other systems? _IF_ there are good reasons for this, why not add this kludge to the reverse lookup code? Oh, and, btw. please only add one Name to the 'From' line. git-am chokes on this; it will drop all real-names and then use the first email-address as the Patch author. If you want to give credit to others, you should probably do so in the changelog message.