On May 27, 2008, at 7:14, Florian Westphal wrote:
I've merged your patch into my tree, ( http://git.breakpoint.cc/cgi-bin/gitweb.cgi?p=fw/ngircd-fw.git;a=shortlog;h=... ), thanks for identifying this issue. Could you please verify that i didn't break anything (i streamlined your change a little)?
From the looks of things, you changed the whitespace on almost every single line in my patch, and moved the Client *c declaration out of the switch statement up to the top of the function. I had the declaration in the case statement (although I forgot to enclose the case in a block) since it's unnecessary elsewhere in the code, but moving it to the top of the function won't break anything.
Since most of the lines in the function changed, it's hard to read the diff to verify that there aren't other subtle changes (only client.c, right?). My tree with your latest client.c builds and tests fine though, so it seems fine.
One important place where I have no test coverage is when destroying a server. That should probably be tested before ship.
./scott