Hi Brett!
Am 23.08.2012 um 21:07 schrieb Brett Smith brett@w3.org:
My boss has given me the green light to spend some time on this, so hopefully I'll have a patch for you soon—later next week, if things go well.
I've done this. My work is at https://gitorious.org/~bretts/ngircd-irc-daemon/bretts-ngircd/commits/move-connection-password.
Great, thanks a lot!
If it'd be more convenient for me to provide it as a single patch or whatever else, just let me know.
No, not at all: sending or referencing individual patches is the best. And using GIT directly or using "git format-patch" (or something similar) is the easiest workflow for me. Thanks.
I also apologize in advance for my rusty and unstylish C. :)
Hehe, but the one to blame here is … me. I wrote all the crappy "endless" lines full of silly whitespaces that clutter our code today. But ok, it's old code.
Today we pretty much adhere to the coding style of the Linux kernel – with some exceptions to make really old compilers happy. And there is a wrapper script for the GNU indent tool, that produces such output: contrib/ngindent. But there is no need to convert all ugly code at one, just let's fix it as we move on …
The uglies thing today are all the silly "function( parameter )" whitespaces ;-)
But at least it works correctly with the basic tests I've been running on password support for our new server. If this isn't quite right, though, please don't hesitate to let me know.
I tested it as well and found no errors.
Its merged in our master branch now.
Regards Alex