Hi all!
It's me again ;-)
I looked into the "ScrubCTCP" and "MorePrivacy" patches of xor (thanks BTW!), and applied them (only slightly modified and adopted to my "newconfig" work) into two branches in my own ngIRCd development repository:
ScrubCTCP is here: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/ScrubCTCP
And MorePrivacy here: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/MorePrivacy
What do you think? xor, do you agree with my changes?
I would include both branches in our next release -- no?
Regards Alex
Alexander Barton alex@barton.de wrote:
I looked into the "ScrubCTCP" and "MorePrivacy" patches of xor (thanks BTW!), and applied them (only slightly modified and adopted to my "newconfig" work) into two branches in my own ngIRCd development repository:
ScrubCTCP is here: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/ScrubCTCP
I am ok with this patch.
And MorePrivacy here: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/MorePrivacy
I wonder what the expected behaviour is when Conf_MorePrivacy is changed from 'yes' to 'no' and the config is reloaded.
At the moment, WHOWAS will start giving out information on Users that were connected during Conf_MorePrivacy=yes period. If this is not wanted, Client_RegisterWhowas() should be changed to not store a record when Conf_MorePrivacy is enabled.
Am 25.06.2011 um 23:12 schrieb Florian Westphal:
And MorePrivacy here: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/MorePrivacy
I wonder what the expected behaviour is when Conf_MorePrivacy is changed from 'yes' to 'no' and the config is reloaded.
At the moment, WHOWAS will start giving out information on Users that were connected during Conf_MorePrivacy=yes period. If this is not wanted, Client_RegisterWhowas() should be changed to not store a record when Conf_MorePrivacy is enabled.
No other comments to this issue?
I think not saving WHOWAS information when MorePrivacy is the better option; will do a „last minute change“ before ngIRCd 18, I think …
Thanks Alex
-
Alexander Barton -
Florian Westphal