Module: ngircd.git Branch: master Commit: ffad2da835e26a1a457d4f4a16acf6797d4cc71e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=ffad2...
Author: Alexander Barton alex@barton.de Date: Wed Sep 10 13:03:30 2014 +0200
Correctly check that a server has a valid hostname and port
David Binderman dcb314@hotmail.com reported the following compiler warning, which is a real bug in ngIRCd, thanks!
conn.c:2077:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
---
src/ngircd/conn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c index 5c175df..6256154 100644 --- a/src/ngircd/conn.c +++ b/src/ngircd/conn.c @@ -1904,7 +1904,7 @@ Check_Servers(void) for (i = 0; i < MAX_SERVERS; i++) { if (Conf_Server[i].conn_id != NONE) continue; /* Already establishing or connected */ - if (!Conf_Server[i].host[0] || !Conf_Server[i].port > 0) + if (!Conf_Server[i].host[0] || Conf_Server[i].port <= 0) continue; /* No host and/or port configured */ if (Conf_Server[i].flags & CONF_SFLAG_DISABLED) continue; /* Disabled configuration entry */