[PATCH] Add tests for MOTD, VERSION, TIME, USERHOST
The misc-test.e file is also somewhat reorganized and commented here. Note the old $Id$ tag from CVS remains and won't be updated. (Thoughts?) --- src/testsuite/misc-test.e | 127 +++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 124 insertions(+), 3 deletions(-) diff --git a/src/testsuite/misc-test.e b/src/testsuite/misc-test.e index 4b88379..f9142df 100644 --- a/src/testsuite/misc-test.e +++ b/src/testsuite/misc-test.e @@ -13,26 +13,147 @@ expect { "376" } +# RFC 2812 Section 3.4.1 + +send "motd\r" +expect { + timeout { exit 1 } + "375" +} +expect { + timeout { exit 1 } + "372" +} +expect { + timeout { exit 1 } + "376" +} + +send "motd ngircd.test.server\r" +expect { + timeout { exit 1 } + "375" +} +expect { + timeout { exit 1 } + "372" +} +expect { + timeout { exit 1 } + "376" +} + +send "motd doesnotexist\r" +expect { + timeout { exit 1 } + "402" +# note this is not specified in RFC 2812, but probably should be +} + +# RFC 2812 Section 3.4.3 + +send "version\r" +expect { + timeout { exit 1 } + "351" +} + +send "version ngircd.test.server\r" +expect { + timeout { exit 1 } + "351" +} + +send "version doesnotexist\r" +expect { + timeout { exit 1 } + "402" +} + +# RFC 2812 Section 3.4.6 + +send "time\r" +expect { + timeout { exit 1 } + "391" +} + +send "time ngircd.test.server\r" +expect { + timeout { exit 1 } + "391" +} + +send "time doesnotexist\r" +expect { + timeout { exit 1 } + "402" +} + +# RFC 2812 Section 3.4.10 + +send "info\r" +expect { + timeout { exit 1 } + "371" +} +expect { + timeout { exit 1 } + "374" +} + +# RFC 2812 Section 4.5 + send "summon\r" expect { timeout { exit 1 } "445" } +# RFC 2812 Section 4.6 + send "users\r" expect { timeout { exit 1 } "446" } -send "info\r" +# RFC 2812 Section 4.8 + +send "userhost\r" expect { timeout { exit 1 } - "371" + "461" } + +send "userhost nick\r" expect { timeout { exit 1 } - "374" + -re ":ngircd.test.server 302 nick :?nick=+.*@(localhost|127.0.0.1)" +} + +send "userhost doesnotexist\r" +expect { + timeout { exit 1 } + ":ngircd.test.server 302 nick :\r" +} + +send "userhost nick doesnotexist nick doesnotexist\r" +expect { + timeout { exit 1 } + -re ":ngircd.test.server 302 nick :nick=+.*@(localhost|127.0.0.1) nick=+.*@(localhost|127.0.0.1)" +} + +send "away :testing\r" +expect { + timeout { exit 1 } + "306 nick" +} + +send "userhost nick nick nick nick nick nick\r" +expect { + timeout { exit 1 } + -re ":ngircd.test.server 302 nick :nick=-.*@(localhost|127.0.0.1) nick=-.*@(localhost|127.0.0.1) nick=-.*@(localhost|127.0.0.1) nick=-.*@(localhost|127.0.0.1) nick=-.*@(localhost|127.0.0.1)\r" } send "quit\r" -- 1.4.4.4
Brandon Beresini <beresini@google.com> wrote:
The misc-test.e file is also somewhat reorganized and commented here. Note the old $Id$ tag from CVS remains and won't be updated. (Thoughts?)
$Id$ tags can be removed along the way. I moved the additional from-line entries to the changelog message before applying the patch, because git-am only expects one entry there. If you give it several, it drops all real-names and uses the first email-address it finds as the Author...
On 2008-05-15 at 11:09 +0200, Florian Westphal wrote:
Oh, and, btw. please only add one Name to the 'From' line. git-am chokes on this; it will drop all real-names and then use the first email-address as the Patch author. If you want to give credit to others, you should probably do so in the changelog message.
Thanks for letting me know about this. The multiple names were my goofy idea. Is there a git-approved way to attach a changelog message? Or do you mean the "commit message" which turns into the message subject?
This is quite a hack... Why is it needed? Why does cygwin need special treatment vs. other systems? _IF_ there are good reasons for this, why not add this kludge to the reverse lookup code?
Good questions. I run neither Cygwin nor Vista, so couldn't test this myself, and decided to pass it along after some formatting adjustments. I hope one of the original authors will reply. On 2008-05-15 at 11:22 +0200, Florian Westphal wrote:
$Id$ tags can be removed along the way.
I almost removed it from misc-test.e, but wasn't sure whether it serves some purpose or whether to replace it with something else. Dana
Dana Dahlstrom <dana+ngIRCd@cs.ucsd.edu> wrote:
line. git-am chokes on this; it will drop all real-names and then use the first email-address as the Patch author. If you want to give credit to others, you should probably do so in the changelog message.
Thanks for letting me know about this. The multiple names were my goofy idea.
Its a nice idea, alright, but it doesn't work ;-)
Is there a git-approved way to attach a changelog message? Or do you mean the "commit message" which turns into the message subject?
Thats what i meant. Basically the first line (which goes into the subject) should be a short one-line summary of the change. Aside from this 'From' thing the patch formatting etc. was fine.
This is quite a hack... Why is it needed? Why does cygwin need special treatment vs. other systems? _IF_ there are good reasons for this, why not add this kludge to the reverse lookup code?
Good questions. I run neither Cygwin nor Vista, so couldn't test this myself, and decided to pass it along after some formatting adjustments. I hope one of the original authors will reply.
Alex Barton pointed me (offlist) to commit 149859c5fecc621cac38df9beb6bb9469ea4c774 so, there are operating systems where 127.0.0.1 will resolve to localhost.<domain>. And there are most certainly installation that will resolve to something else. I also remember seeing 'localhost6' on some system when ipv6 is used. So, in short, i'd really like to stay away from meddling with domain names inside ngircd... Regards, Florian
Teilnehmer (3)
-
Brandon Beresini -
Dana Dahlstrom -
Florian Westphal