nick length is too short, how to change this?
Hello, I have a few users very unhappy with the maximum nickname length value so i tried to change it (failing miserably); i modified some .h file in the source code where i thought the nickname length was defined but the server still won't accept nicknames longer than 9 characters - I'm no coder. What can I do now? Please help! Thanks! -- _______________________________________ Disclaimer: This message and any attachments thereto are intended solely for the addressed recipient(s) and may contain confidential information. If you are not the intended recipient, please notify the sender by reply e-mail and delete the e-mail (including any attachments thereto) without producing, distributing or retaining any copies thereof. Any review, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient(s) is prohibited. Thank you.
On Jul 28, 2004, at 4:20 PM, Lucian wrote:
Hello, I have a few users very unhappy with the maximum nickname length value so i tried to change it (failing miserably); i modified some .h file in the source code where i thought the nickname length was defined but the server still won't accept nicknames longer than 9 characters - I'm no coder. What can I do now? Please help! Thanks!
This is the line of code to change: #define CLIENT_NICK_LEN 30 /* max. Nick-Laenge; vgl. RFC 2812, 1.2.1 */ It's line 41 in defines.h (at least in my 0.8.0 version here). --- Jack Quis custodiet ipsos custodes?
Am 29. Jul 2004 um 0:24 Uhr schrieb Jack Beckman:
On Jul 28, 2004, at 4:20 PM, Lucian wrote:
Hello, I have a few users very unhappy with the maximum nickname length value so i tried to change it (failing miserably); i modified some .h file in the source code where i thought the nickname length was defined but the server still won't accept nicknames longer than 9 characters - I'm no coder. What can I do now? Please help! Thanks!
This is the line of code to change:
#define CLIENT_NICK_LEN 30 /* max. Nick-Laenge; vgl. RFC 2812, 1.2.1 */
It's line 41 in defines.h (at least in my 0.8.0 version here).
Right, defines.h is in src/ngircd/. The file and CLIENT_NICK_LEN exist since the verry first release of ngIRCd, 0.0.1, dated 2001-12-31 :-)) CLIENT_NICK_LEN specifies the maximum length of nick names including a trailing NULL character. The default is 10 bytes, resulting in 9 usable characters for the end-user plus one byte for the NULL byte. And please note: - changing CLIENT_NICK_LEN isn't tested by me at all! Feedback welcome. - all servers in a network MUST use the same nick-name length! Regards Alex -- Alexander Barton, Freiburg, Germany http://www.barton.de/, alex@barton.de
I don't connect to any network, so it's not a problem for me. I have run this way in 7.6 and 8.0 with no problems whatsoever. Again, my server is stand-alone. On Jul 28, 2004, at 7:48 PM, Alexander Barton wrote:
And please note: - changing CLIENT_NICK_LEN isn't tested by me at all! Feedback welcome. - all servers in a network MUST use the same nick-name length!
--- Jack Quis custodiet ipsos custodes?
Jack Beckman <jbeckman@beckmanjm.com> wrote:
I don't connect to any network, so it's not a problem for me. I have run this way in 7.6 and 8.0 with no problems whatsoever. Again, my server is stand-alone.
Same here. The long names work fine on a single server. BTW: Changing the code so that no rooms except the predefined can be opened works fine, too ;-) Yours Jens
Jens Kleine wrote:
Same here. The long names work fine on a single server.
Good to hear :-) The nick name length should become a configuration option, I think. A lot of people want to change it ... A run-time option in ngircd.conf would be a bit trickier, but what about a ./configure option à la "--with-nick-length=30"?
BTW: Changing the code so that no rooms except the predefined can be opened works fine, too ;-)
Ah, interesting. Do you have a patch for this? Could be useful for more people and eventually become a ./configure option, too ... Regards Alex -- Alexander Barton, Freiburg, Germany alex@barton.de, http://www.barton.de/
Alexander Barton <alex@barton.de> wrote:
Ah, interesting. Do you have a patch for this? Could be useful for more people and eventually become a ./configure option, too ...
I just changed (keep changing with new versions) the channel.c from line 162 to: { /* Gibt es noch nicht? Dann neu anlegen: */ /* chan = Channel_Create( Name ); if( ! chan ) return FALSE; */ return FALSE; } It's returning FALSE everytime somebody tries to create a new channel so nobody can use the server I keep running for a fanclub for there personal purposes and just the 2 predifined channels the fanclub needs exist. Yours Jens
On Jul 29, 2004, at 2:10 PM, Jens Kleine wrote:
Alexander Barton <alex@barton.de> wrote:
Ah, interesting. Do you have a patch for this? Could be useful for more people and eventually become a ./configure option, too ...
I just changed (keep changing with new versions) the channel.c from line 162 to: { /* Gibt es noch nicht? Dann neu anlegen: */ /* chan = Channel_Create( Name ); if( ! chan ) return FALSE; */ return FALSE; } It's returning FALSE everytime somebody tries to create a new channel so nobody can use the server I keep running for a fanclub for there personal purposes and just the 2 predifined channels the fanclub needs exist.
Maybe if it could be restricted so only server operators could create a channel? I think being able to turn this on/off globally would be a good ./configure option - I too run a private server for a club. ---- Jack Quis custodiet ipsos custodes? ---- Jack Quis custodiet ipsos custodes?
On Thu, Jul 29, 2004 at 02:45:35PM -0400, Jack Beckman wrote:
On Jul 29, 2004, at 2:10 PM, Jens Kleine wrote:
Alexander Barton <alex@barton.de> wrote:
Ah, interesting. Do you have a patch for this? Could be useful for more people and eventually become a ./configure option, too ...
I just changed (keep changing with new versions) the channel.c from line 162 to: { /* Gibt es noch nicht? Dann neu anlegen: */ /* chan = Channel_Create( Name ); if( ! chan ) return FALSE; */ return FALSE; } It's returning FALSE everytime somebody tries to create a new channel so nobody can use the server I keep running for a fanclub for there personal purposes and just the 2 predifined channels the fanclub needs exist.
Maybe if it could be restricted so only server operators could create a channel?
This should be no problem (and another reason for intoducing a "half op" status ...).
I think being able to turn this on/off globally would be a good ./configure option - I too run a private server for a club.
Hm, thinking about it ... a run-time option in ngircd.conf would probably make more sense (and would be more flexible). Regards Alex -- Alexander Barton, Freiburg, Germany alex@barton.de, http://www.barton.de/
On Thu, Jul 29, 2004 at 08:10:52PM +0200, Jens Kleine wrote:
Ah, interesting. Do you have a patch for this? Could be useful for more people and eventually become a ./configure option, too ...
I just changed (keep changing with new versions) the channel.c from line 162 to: { /* Gibt es noch nicht? Dann neu anlegen: */ /* chan = Channel_Create( Name ); if( ! chan ) return FALSE; */ return FALSE; } It's returning FALSE everytime somebody tries to create a new channel so nobody can use the server I keep running for a fanclub for there personal purposes and just the 2 predifined channels the fanclub needs exist.
I see. But this only works with a stand-alone server and will break networked environments when an other servers announces that a user has joined a channel. Okay, probably no problem for your case :-) The solution would be to make IRC_JOIN (irc-channel.c) more clever and only call Channel_Join() when a) the JOIN was received from a server or b) the channel already exists. Regards Alex -- Alexander Barton, Freiburg, Germany alex@barton.de, http://www.barton.de/
thanks guys, it worked! I'm running a standalone server for a small community so I'm not worried about problems that may appear regarding server linking and stuff. Keep up the good job! On Wed, 28 Jul 2004 23:20:22 +0300, Lucian <selfaware@gmail.com> wrote:
Hello, I have a few users very unhappy with the maximum nickname length value so i tried to change it (failing miserably); i modified some .h file in the source code where i thought the nickname length was defined but the server still won't accept nicknames longer than 9 characters - I'm no coder. What can I do now? Please help! Thanks! -- _______________________________________ Disclaimer: This message and any attachments thereto are intended solely for the addressed recipient(s) and may contain confidential information. If you are not the intended recipient, please notify the sender by reply e-mail and delete the e-mail (including any attachments thereto) without producing, distributing or retaining any copies thereof. Any review, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient(s) is prohibited.
Thank you.
-- _______________________________________ Disclaimer: This message and any attachments thereto are intended solely for the addressed recipient(s) and may contain confidential information. If you are not the intended recipient, please notify the sender by reply e-mail and delete the e-mail (including any attachments thereto) without producing, distributing or retaining any copies thereof. Any review, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient(s) is prohibited. Thank you.
participants (5)
-
Alexander Barton -
Alexander Barton -
Jack Beckman -
Jens Kleine -
Lucian