Re: [ngIRCd-ML] patch for missing RPL_WHOREPLY flags

Dana Dahlstrom dana+70@cs.ucsd.edu wrote:

RPL_WHOREPLY messages generated by IRC_WHO don't include flags (*,@,+) that should appear according to this description:

You're right; also applied.

Alex, this is getting silly as CVS cannot properly track individual patch authors; this would IMO work much better if we'd switch over to git.

(1) The modifications to irc-info.c on lines 767-772 create even more code duplicated in both IRC_WHO and IRC_Send_WHO. These functions could probably benefit from some refactoring.

Yes. I'll look at this again tomorrow.

(2) The file who-away-test.e, especially as modified here, would probably be more accurately called simply who-test.e.

Indeed, i renamed it (another thing which git does much better...).