Module: ngircd.git Branch: master Commit: 2196e945e4ac5f41d6650c4ceb9120cfd8fc8d56 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=2196e...

Author: Alexander Barton alex@barton.de Date: Thu Mar 12 00:28:31 2015 +0100

Fix "WHO #<chan>" showing invisible users and hiding all visible

The logic is reversed ...

This bug has been introduced by commit c74115f2, "Simplify mode checking on channels and users within a channel", ngIRCd releases 21, 21.1, and 22 are affected :-(

Problem reported by Cahata in #ngircd, Thanks!

---

src/ngircd/irc-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c index 763c930..61c6239 100644 --- a/src/ngircd/irc-info.c +++ b/src/ngircd/irc-info.c @@ -162,7 +162,7 @@ IRC_WHO_Channel(CLIENT *Client, CHANNEL *Chan, bool OnlyOps) if (OnlyOps && !is_ircop) continue;

- is_visible = Client_HasMode(c, 'i'); + is_visible = !Client_HasMode(c, 'i'); if (is_member || is_visible) { memset(flags, 0, sizeof(flags));