Module: ngircd.git Branch: master Commit: 05748aa5eeaf75438a0bb238967667605fe4d52e URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=05748...
Author: Florian Westphal fw@strlen.de Date: Fri Apr 29 23:15:05 2011 +0200
parse: fix logical expression testing for non RFC1459 links
parse.c:284: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
The expression looks dubious, this should probably be an if-not-set, then... test.
---
src/ngircd/parse.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/ngircd/parse.c b/src/ngircd/parse.c index d7dbffc..c260391 100644 --- a/src/ngircd/parse.c +++ b/src/ngircd/parse.c @@ -280,7 +280,7 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Closed ) assert( client != NULL );
if (!Req->prefix && Client_Type(client) == CLIENT_SERVER - && !Conn_Options(Idx) & CONN_RFC1459 + && !(Conn_Options(Idx) & CONN_RFC1459) && strcasecmp(Req->command, "ERROR") != 0 && strcasecmp(Req->command, "PING") != 0) {