[ngIRCd-GIT-ML] Alexander Barton : Fix a buffer overflow when initializing the random salt for "+x"

Module: ngircd.git Branch: master Commit: d48e440a722cb56fd3c2996d2d3c87ce7f471042 URL: http://ngircd.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git&a=commit;h=d48e4...

Author: Alexander Barton alex@barton.de Date: Thu Aug 16 23:51:28 2012 +0200

Fix a buffer overflow when initializing the random salt for "+x"

This "off by one" buffer overflow has been introduced in commit 49385a98, "Implemented hashed cloaked hostnames for +x".

---

src/ngircd/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ngircd/conf.c b/src/ngircd/conf.c index b091137..923cdc0 100644 --- a/src/ngircd/conf.c +++ b/src/ngircd/conf.c @@ -653,7 +653,7 @@ static void Set_Defaults(bool InitServers) { int i; - char random[RANDOM_SALT_LEN]; + char random[RANDOM_SALT_LEN + 1];

/* Global */ strcpy(Conf_ServerName, "");